feat: add list_embedding_models_async to OpenRouterProvider - #3089
Open
majiayu000 wants to merge 1 commit into
Open
feat: add list_embedding_models_async to OpenRouterProvider#3089majiayu000 wants to merge 1 commit into
majiayu000 wants to merge 1 commit into
Conversation
OpenRouter's /models endpoint doesn't list embedding models, but they support OpenAI's embedding models via the /embeddings endpoint. This change adds hardcoded EmbeddingConfig objects for the known supported models (text-embedding-3-small and text-embedding-3-large). Fixes letta-ai#3086
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_embedding_models_async()method toOpenRouterProviderclassEmbeddingConfigobjects for OpenAI embedding models supported by OpenRouterProblem
When using OpenRouter as an LLM provider, Letta cannot discover embedding models because OpenRouter's
/modelsendpoint only returns LLM models, not embedding models.Current behavior:
letta/letta-freeembedding model appears in the UI/APIopenai/text-embedding-3-small) are not discoverableRoot cause:
OpenRouter's
/modelsendpoint doesn't list embedding models, but they support OpenAI's embedding models via the/embeddingsendpoint.Solution
Added
list_embedding_models_async()method toOpenRouterProviderclass that returns hardcodedEmbeddingConfigobjects for:openai/text-embedding-3-small(1536 dimensions)openai/text-embedding-3-large(3072 dimensions)Test plan
test_openrouter_embedding_models_without_api_keythat verifies embedding models are returned correctly without making API callstest_openrouter(requiresOPENROUTER_API_KEY)Fixes #3086