Fix missing passing grade #253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔀 Purpose of this PR:
📝 Description:
This PR fixes #251.
Part of the completion conditions for activity completions are conditions regarding a users grade. Teacher can depend the completion on a passing grade.
What was the problem?
Moodleoverflow did not have a passing grade setting. As the moodle core accepts passing grades as completion conditions, a teacher could set the passing grade as condition but the
mod_form-validation returned the error that a passing grade needs to be set, although there was no possibility to set it.What was the solution?
A new field is added to
mod_formin the grades section where a teacher can set a passing grade. This field is recognized automatically by themod_formand handled correctly. A new field is added to the database as well as the setting needs to be saved if the teacher wants to change it.📋 Checklist
Please confirm the following (check all that apply):
var_dump()orvar_exportor any other debugging statements (or commented out code) thatshould not appear on the productive branch.
db/upgrade.phpandupdated the
version.php.🔍 Related Issues