Skip to content

Conversation

@kart-u
Copy link
Contributor

@kart-u kart-u commented Oct 30, 2025

Summary

Issues:-

  1. Migration of file modals from Vuetify to Kolibri Design System in Uploader.vue & ThumbnailGenerator.vue
  2. Removal of Alert.vue
  3. Use tokens.annotation instead of currently hardcoded light gray

Description of changes:-

  1. changed Alert modal to KModal in both files
  2. removed Alert.vue file
  3. added :style="{ color: $themeTokens.annotation }" for tokens.annotation

Manual Testing Results

greater_10 invalid_file max_file thumbnail_error

References

Closes #5472

@MisRob MisRob changed the title Refactor:alert dialog [Remove Vuetify from Studio] Alert dialog Oct 31, 2025
@MisRob MisRob self-requested a review October 31, 2025 17:11
@MisRob MisRob self-assigned this Oct 31, 2025
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Studio codebase @kart-u. Nice first contribution. Just few cleanup notes, then should be good for merge.

@kart-u kart-u requested a review from MisRob November 3, 2025 11:15
@kart-u
Copy link
Contributor Author

kart-u commented Nov 4, 2025

Hi @MisRob, I’ve refactored the code as requested. Could you please review and confirm if it looks good?

@MisRob
Copy link
Member

MisRob commented Nov 4, 2025

Thank you, @kart-u, it's on my review list - I will follow-up with you.

@bjester
Copy link
Member

bjester commented Nov 5, 2025

The frontend test suite seems to be timing out. @kart-u It's possible the corresponding frontend tests need updated for the changes here, i.e. maybe uploader.spec.js. Would you please take a look and see if you can reproduce and resolve this issue?

@kart-u
Copy link
Contributor Author

kart-u commented Nov 5, 2025

@bjester yes I will look into this

@kart-u
Copy link
Contributor Author

kart-u commented Nov 5, 2025

@bjester corrected test now working fine on my local tests
image
ThumbnailGenerator
image
uploader.spec
image
all test result

Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of the test too @kart-u @bjester. I don't quite understand why tests started timing out on this opportunity, but I read the test suite and the component - given the way it works now and what the test suite attempts to check, I think that the change is meaningful.

As for the alerts, I previewed them and confirm that they work as expected. Code changes make sense. Thanks!

@MisRob MisRob merged commit 2884bd0 into learningequality:unstable Nov 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Remove Vuetify from Studio] Alert dialog

3 participants