Migrate setup_wizard to the new resource layer - #15182
Open
rtibblesbot wants to merge 3 commits into
Open
Conversation
cancel/restart/clearAll are wire-identical to their _v2 pairs; every call site discards the resolved value, so the envelope-to-body change is invisible.
github-actions
Bot
added
APP: Setup Wizard
Contributor
Build Artifacts
Smoke test screenshot |
rtibblesbot
marked this pull request as ready for review
August 12, 2026 16:24
Both resources are plugin-local, so the recipe's in-place rewrite applies rather than a _v2 pair. The four methods now resolve with the response body, which LodJoinFacility destructures one level up.
No caller anywhere in kolibri/ or packages/, and a line-for-line duplicate of FacilityUserResource.listRemoteFacilityLearners, which ImportIndividualUserForm already calls. Its removal takes the last client/urls imports with it.
rtibblesbot
force-pushed
the
issue-15063-2e6867
branch
from
August 12, 2026 16:33
fe7cda9 to
de6de4b
Compare
Contributor
Author
|
The red |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TaskResource.{cancel,restart,clearAll}call sites now use the_v2methods.SetupWizardResourceandFacilityImportResourceare plugin-local, so their four custom methods are rewritten in place ontorequestrather than paired with a_v2.LodJoinFacility.vuedestructures one level up;facilityadminsalready did.FacilityImportResource.listfacilitylearners— uncalled, and a duplicate ofFacilityUserResource.listRemoteFacilityLearners.References
Closes #15063. Recipe: #15057.
_v2methods: #15162.Reviewer guidance
Resource.logError, whichaccessListEndpointnever called. A wrong password onSelectSuperAdminAccountForm.vue:175now emits aRequest error:group — confirm that is acceptable.useListconversion: the threeTaskResource.listsites aresetTimeoutpolling loops, anduseListwraps a singlelist()with no polling.AI usage
Used Claude Code to apply the shared migration recipe across the plugin and to write the resource spec covering the four rewritten methods. Verified with the setup_wizard Jest suite and prek.
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
🟡 Waiting for feedback
Last updated: 2026-08-12 18:20 UTC