fix: don't skip docs in multi-library situations#363
Merged
hargoniX merged 4 commits intoleanprover:mainfrom Feb 24, 2026
Merged
fix: don't skip docs in multi-library situations#363hargoniX merged 4 commits intoleanprover:mainfrom
hargoniX merged 4 commits intoleanprover:mainfrom
Conversation
Fixes a bug in leanprover#347 that caused multi-library builds to skip generating HTML for some libraries. The issue was that the Lake setup used declaration-data.bmp as its build target. Multiple-library builds would populate the database, but then only the one that won the race would generate its declaration-data.bmp. The others would incorrectly see that it existed and generate no HTML. Now, the same "marker file" approach is used as the database content to indicate that HTML for a given module, library, or package is up to date. This gives them the right traces, and allows declaration-data.bmp to be updated as needed. A regression test is also included.
Rather than sending pragmas in strings, it's nicer to use a higher-level API.
This reverts commit b95beb5. It will be sent in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a race condition in #347 that caused multi-library builds to skip generating HTML for some libraries.
The issue was that the Lake setup used declaration-data.bmp as its build target. Multiple-library builds would populate the database, but then only the one that won the race would generate its declaration-data.bmp. The others would incorrectly see that it existed and generate no HTML.
Now, the same "marker file" approach is used as the database content to indicate that HTML for a given module, library, or package is up to date. This gives them the right traces, and allows declaration-data.bmp to be updated as needed.
A regression test is also included.