Skip to content

[Merged by Bors] - chore(Analysis/InnerProductSpace): fix eigenvalue_pos_of_pos - #42929

Closed
mcdoll wants to merge 2 commits into
leanprover-community:masterfrom
mcdoll:boguslemma
Closed

[Merged by Bors] - chore(Analysis/InnerProductSpace): fix eigenvalue_pos_of_pos#42929
mcdoll wants to merge 2 commits into
leanprover-community:masterfrom
mcdoll:boguslemma

Conversation

@mcdoll

@mcdoll mcdoll commented Aug 19, 2026

Copy link
Copy Markdown
Member

The current statement of the lemma eigenvalue_pos_of_pos is non-sense as its assumption can never be satisfied (it is always violated for x=0). Fix this; also remove some type annotations that are completely unnecessary.


import Mathlib.Analysis.InnerProductSpace.Spectrum

variable {𝕜 E : Type*} [RCLike 𝕜] [NormedAddCommGroup E] [InnerProductSpace 𝕜 E]

local notation "⟪" x ", " y "⟫" => inner 𝕜 x y

open Module.End

theorem false_of_pos {μ : ℝ} {T : E →ₗ[𝕜] E} (_hμ : HasEigenvalue T μ)
    (hnn : ∀ x : E, 0 < RCLike.re ⟪x, T x⟫) : False := by
  suffices ¬∀ x : E, 0 < RCLike.re ⟪x, T x⟫ from this hnn
  simp only [not_forall, not_lt]
  use 0
  simp

Also remove some type annotations that are completely unnecessary.


Open in Gitpod

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown

PR summary f24777c72c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit f24777c).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit f24777c72c
Reference commit 818f61df41

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-analysis Analysis (normed *, calculus) label Aug 19, 2026
@mcdoll mcdoll added the easy < 20s of review time. See the lifecycle page for guidelines. label Aug 19, 2026
@grunweg

grunweg commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Good find, thanks! I've shortened your PR description a bit (since right now, the description is longer than the fix). If you disagree with this, feel free to edit it back.
bors d+

@mathlib-bors mathlib-bors Bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Aug 19, 2026
@mathlib-bors

mathlib-bors Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

✌️ mcdoll can now approve this pull request until 2026-09-02 08:06 UTC (in 2 weeks). To approve and merge, reply with bors r+. More detailed instructions are available here.

⚠️ This delegation only covers changes within Archive/**, Counterexamples/**, docs/**, DownstreamTest/**, Mathlib/**, MathlibTest/**, Wanted/**, widget/**, Archive.lean, Counterexamples.lean, docs.lean, Mathlib.lean, Wanted.lean; an author commit touching anything else will revoke it. Bors also revokes it if a later push changes too many files for it to check the full list — even if it stays within scope.

@mcdoll

mcdoll commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

Thanks, yes the example should not be part of the commit message.
bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Aug 19, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Aug 19, 2026
The current statement of the lemma `eigenvalue_pos_of_pos` is non-sense as its assumption can never be satisfied (it is always violated for `x=0`). Fix this; also remove some type annotations that are completely unnecessary.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Aug 19, 2026
@mathlib-bors

mathlib-bors Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(Analysis/InnerProductSpace): fix eigenvalue_pos_of_pos [Merged by Bors] - chore(Analysis/InnerProductSpace): fix eigenvalue_pos_of_pos Aug 19, 2026
@mathlib-bors mathlib-bors Bot closed this Aug 19, 2026
@mathlib-bors mathlib-bors Bot removed the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants