Skip to content

feat(Algebra/Group): prod and pi instances for IsDedekindFinite - #42927

Open
NoahW314 wants to merge 1 commit into
leanprover-community:masterfrom
NoahW314:IsDedekindFinite
Open

feat(Algebra/Group): prod and pi instances for IsDedekindFinite#42927
NoahW314 wants to merge 1 commit into
leanprover-community:masterfrom
NoahW314:IsDedekindFinite

Conversation

@NoahW314

Copy link
Copy Markdown
Contributor

Open in Gitpod

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown

PR summary 9a7211c595

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ instance [MulOneClass M] [MulOneClass N] [IsDedekindFiniteMonoid M] [IsDedekindFiniteMonoid N] :
+ instance [∀ i, MulOneClass (f i)] [∀ i, IsDedekindFiniteMonoid (f i)] :

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 9a7211c).

  • +4 new declarations
  • −0 removed declarations
+Pi.instIsDedekindFiniteAddMonoidForall
+Pi.instIsDedekindFiniteMonoidForall
+Prod.instIsDedekindFiniteAddMonoid
+Prod.instIsDedekindFiniteMonoid

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 9a7211c595
Reference commit 4ac22c7efc

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Aug 19, 2026
@NoahW314

Copy link
Copy Markdown
Contributor Author

easy

@github-actions github-actions Bot added the easy < 20s of review time. See the lifecycle page for guidelines. label Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant