feat(NumberTheory/RamificationInertia/Unramified): generalize IsUnramifiedAt.of_liesOver to flat algebras - #42919
Open
tb65536 wants to merge 3 commits into
Open
feat(NumberTheory/RamificationInertia/Unramified): generalize IsUnramifiedAt.of_liesOver to flat algebras#42919tb65536 wants to merge 3 commits into
IsUnramifiedAt.of_liesOver to flat algebras#42919tb65536 wants to merge 3 commits into
Conversation
PR summary cc790ce8a4
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.Flat.FaithfullyFlat.Algebra | 1737 | 1741 | +4 (+0.23%) |
Import changes for all files
| Files | Import difference |
|---|---|
3 filesMathlib.RingTheory.Flat.FaithfullyFlat.Algebra Mathlib.RingTheory.LocalRing.Length Mathlib.RingTheory.TensorProduct.IncludeLeftSubRight |
4 |
Declarations diff (regex)
+ IsUnramifiedAt.map_eq
+ instance [Module.Flat A B] (p : Ideal A) (q : Ideal B) [p.IsPrime] [q.IsPrime] [q.LiesOver p]
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit
cc790ce).
- +2 new declarations
- −0 removed declarations
+Algebra.IsUnramifiedAt.map_eq
+instFaithfullyFlatAtPrimeOfFlatOfIsLiesOverAlgebraNo changes to strong technical debt.
No changes to weak technical debt.
Current commit cc790ce8a4
Reference commit b948c053cf
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generalizes
IsUnramifiedAt.of_liesOverto flat algebras and deprecates the technical auxiliary lemmaIsUnramifiedAt.of_liesOver_of_ne_botfor the previous proof.This also avoids the usage of the old
Ideal.ramificationIdx'.