Skip to content

chore: fix minor spacing issues - #42918

Open
felixpernegger wants to merge 2 commits into
leanprover-community:masterfrom
felixpernegger:rodspacing
Open

chore: fix minor spacing issues#42918
felixpernegger wants to merge 2 commits into
leanprover-community:masterfrom
felixpernegger:rodspacing

Conversation

@felixpernegger

Copy link
Copy Markdown
Contributor

Done via regex. Replaces \w ] with \w] basically.

I have previously been adviced against PRs like this due to a future autoformatter, but:

  • This PR is very easy to review

  • It is not clear to me at all an autoformatter would include this


Open in Gitpod

@felixpernegger

Copy link
Copy Markdown
Contributor Author

easy

@github-actions github-actions Bot added the easy < 20s of review time. See the lifecycle page for guidelines. label Aug 18, 2026
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

PR summary 7378cd9a10

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 7378cd9).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 7378cd9a10
Reference commit abea25c40f

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg

grunweg commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

It is not clear to me at all an autoformatter would include this

We can find out by asking the author:
@hargoniX is the autoformatter going to include changes like this PR from the start? (My impression certainly is that this would be possible to implement, it is a kind of syntax canonisation pass after all.)

@grunweg grunweg added the awaiting-zulip There is a Zulip discussion; the author should await and report/implement the decision reached there label Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-zulip There is a Zulip discussion; the author should await and report/implement the decision reached there easy < 20s of review time. See the lifecycle page for guidelines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants