Skip to content

[Merged by Bors] - feat(NumberTheory/Padics): the Amice transform - #42832

Closed
loefflerd wants to merge 9 commits into
leanprover-community:masterfrom
loefflerd:DL_amice
Closed

[Merged by Bors] - feat(NumberTheory/Padics): the Amice transform#42832
loefflerd wants to merge 9 commits into
leanprover-community:masterfrom
loefflerd:DL_amice

Conversation

@loefflerd

Copy link
Copy Markdown
Contributor

Prove the Amice (aka Leopoldt) transform isomorphism, identifying Zp-valued measures on Zp with the power series ring ℤ_[p]⟦X⟧.


Open in Gitpod

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown

PR summary a5079844eb

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.NumberTheory.Padics.Measure.AmiceTransform (new file) 2113

Declarations diff (regex)

+ AbstractMeasure.ext_mahler
+ amiceTransform
+ amiceTransformEquiv
+ amiceTransformEquiv_apply
+ amiceTransform_invTransform
+ arrowCongrLeft
+ arrowCongrLeft_apply
+ arrowCongrLeft_symm
+ coe_arrowCongrLeft
+ coeff_amiceTransform
+ coeff_amiceTransformEquiv
+ dense_span_mahler
+ ext_mahler
+ injective_amiceTransform
+ invTransform
+ invTransformSummable
+ invTransform_apply
+ invTransformₗ

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit a507984).

  • +18 new declarations
  • −0 removed declarations
+AbstractMeasure.amiceTransform
+AbstractMeasure.amiceTransform.congr_simp
+AbstractMeasure.amiceTransformEquiv
+AbstractMeasure.amiceTransformEquiv_apply
+AbstractMeasure.amiceTransform_invTransform
+AbstractMeasure.arrowCongrLeft
+AbstractMeasure.arrowCongrLeft_apply
+AbstractMeasure.arrowCongrLeft_symm
+AbstractMeasure.coe_arrowCongrLeft
+AbstractMeasure.coeff_amiceTransform
+AbstractMeasure.coeff_amiceTransformEquiv
+AbstractMeasure.ext_mahler
+AbstractMeasure.injective_amiceTransform
+AbstractMeasure.invTransform
+AbstractMeasure.invTransform_apply
+PadicInt.dense_span_mahler
+PadicInt.ext_mahler
+PadicInt.mahlerEquiv.congr_simp

No changes to strong technical debt.
No changes to weak technical debt.

Current commit a5079844eb
Reference commit 61eda68641

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@loefflerd loefflerd changed the title feat(NumberTheory/Padics): Amice transform feat(NumberTheory/Padics): the Amice transform Aug 16, 2026
@loefflerd loefflerd added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Aug 16, 2026
@loefflerd
loefflerd requested a review from faenuccio August 16, 2026 17:02
@faenuccio faenuccio self-assigned this Aug 19, 2026
@faenuccio faenuccio added the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 24, 2026

@faenuccio faenuccio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I made some comments concerning the files Padics/Measure/Basic, Algebra/Group/ForwardDiff and up to the end of the defs section in AmiceTransform.lean.

Comment thread Mathlib/NumberTheory/Padics/Measure/Basic.lean
Comment thread Mathlib/NumberTheory/Padics/Measure/Basic.lean
Comment thread Mathlib/NumberTheory/Padics/Measure/AmiceTransform.lean Outdated
Comment thread Mathlib/NumberTheory/Padics/Measure/AmiceTransform.lean Outdated
Comment thread Mathlib/NumberTheory/Padics/Measure/AmiceTransform.lean Outdated
Comment thread Mathlib/NumberTheory/Padics/Measure/AmiceTransform.lean Outdated
Comment thread Mathlib/NumberTheory/Padics/Measure/AmiceTransform.lean Outdated
Comment thread Mathlib/NumberTheory/Padics/Measure/AmiceTransform.lean Outdated
Comment thread Mathlib/NumberTheory/Padics/Measure/AmiceTransform.lean Outdated
Comment thread Mathlib/NumberTheory/Padics/Measure/AmiceTransform.lean
Comment thread Mathlib/NumberTheory/Padics/Measure/AmiceTransform.lean Outdated
@loefflerd

Copy link
Copy Markdown
Contributor Author

Many thanks for the very careful and detailed review, Filippo!

@loefflerd loefflerd removed the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 25, 2026
@faenuccio faenuccio added the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 25, 2026

@faenuccio faenuccio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, I've finished reviewing the Amice file and have suggested a bit of golfing. Besides this, I guess the main "point" is whether we want to move things a bit as discussed further up.

Comment thread Mathlib/NumberTheory/Padics/Measure/AmiceTransform.lean Outdated
Comment thread Mathlib/NumberTheory/Padics/Measure/AmiceTransform.lean Outdated
Comment thread Mathlib/NumberTheory/Padics/Measure/AmiceTransform.lean Outdated
Comment thread Mathlib/NumberTheory/Padics/Measure/AmiceTransform.lean Outdated
Comment thread Mathlib/NumberTheory/Padics/Measure/AmiceTransform.lean Outdated
Comment thread Mathlib/NumberTheory/Padics/Measure/AmiceTransform.lean Outdated
@loefflerd

Copy link
Copy Markdown
Contributor Author

Thanks for all these great comments! I believe I've now dealt with everything except the query about scalar multiplication with 1 : C(ℤ_[p], R). Let me know how you think we should proceed with that one.

@loefflerd loefflerd removed the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 25, 2026
Comment thread Mathlib/NumberTheory/Padics/Measure/AmiceTransform.lean
@faenuccio

Copy link
Copy Markdown
Contributor

bors d+

@mathlib-bors mathlib-bors Bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Aug 26, 2026
@mathlib-bors

mathlib-bors Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

✌️ loefflerd can now approve this pull request until 2026-09-09 20:27 UTC (in 2 weeks). To approve and merge, reply with bors r+. More detailed instructions are available here.

⚠️ This delegation only covers changes within Archive/**, Counterexamples/**, docs/**, DownstreamTest/**, Mathlib/**, MathlibTest/**, Wanted/**, widget/**, Archive.lean, Counterexamples.lean, docs.lean, Mathlib.lean, Wanted.lean; an author commit touching anything else will revoke it. Bors also revokes it if a later push changes too many files for it to check the full list — even if it stays within scope.

@faenuccio

Copy link
Copy Markdown
Contributor

Thanks for all these great comments! I believe I've now dealt with everything except the query about scalar multiplication with 1 : C(ℤ_[p], R). Let me know how you think we should proceed with that one.

I've replied in a stream which might look "outdated", but I hope you can find the reply nonetheless.

@loefflerd

Copy link
Copy Markdown
Contributor Author

bors r+

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Aug 27, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Aug 27, 2026
Prove the Amice (aka Leopoldt) transform isomorphism, identifying Zp-valued measures on Zp with the power series ring `ℤ_[p]⟦X⟧`.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Aug 27, 2026
@mathlib-bors

mathlib-bors Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title feat(NumberTheory/Padics): the Amice transform [Merged by Bors] - feat(NumberTheory/Padics): the Amice transform Aug 27, 2026
@mathlib-bors mathlib-bors Bot closed this Aug 27, 2026
@mathlib-bors mathlib-bors Bot removed the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants