[Merged by Bors] - chore(ci): wire MATHLIB_CACHE_BASE_URL from a repository variable - #42777
Closed
marcelolynch wants to merge 1 commit into
Closed
Conversation
PR summary c166c7c40dImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
marcelolynch
force-pushed
the
2026/08/CacheBaseURLWiring
branch
from
August 14, 2026 18:01
624eaa9 to
c166c7c
Compare
marcelolynch
marked this pull request as ready for review
August 14, 2026 18:07
Contributor
|
Thanks! |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Aug 20, 2026
…2777) This PR passes the repository variable `MATHLIB_CACHE_BASE_URL` to every workflow that reads the mathlib cache: `build_template.yml` (which serves the build, fork, bors, ci_dev, and release_cache workflows), `olean_report.yaml`, `remove_deprecated_decls.yml`, and the warm-start `cache get` in `lake_cache_shadow.yml`. The variable is normally unset, so reads keep their current path to Azure. An operator sets the variable to move cache read traffic to another host, and clears it to move the traffic back. Both changes take effect on the next job, with no deploy and no code change. The tool side is #42657: the cache tool reads `MATHLIB_CACHE_BASE_URL` and treats an empty value as unset, which is the state `${{ vars.MATHLIB_CACHE_BASE_URL }}` produces while the variable is undefined. The two PRs are safe in either merge order: before #42657 the tool ignores the variable, and after it the empty value keeps the default. Out of scope: the `nightly-testing` repository has its own variable namespace, so a flip there is a separate switch. `publish_tools.yml` and `cache_test.yml` run no cache reads, so they stay unwired.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR passes the repository variable
MATHLIB_CACHE_BASE_URLto every workflow that reads the mathlib cache:build_template.yml(which serves the build, fork, bors, ci_dev, and release_cache workflows),olean_report.yaml,remove_deprecated_decls.yml, and the warm-startcache getinlake_cache_shadow.yml. The variable is normally unset, so reads keep their current path to Azure. An operator sets the variable to move cache read traffic to another host, and clears it to move the traffic back. Both changes take effect on the next job, with no deploy and no code change.The tool side is #42657: the cache tool reads
MATHLIB_CACHE_BASE_URLand treats an empty value as unset, which is the state${{ vars.MATHLIB_CACHE_BASE_URL }}produces while the variable is undefined. The two PRs are safe in either merge order: before #42657 the tool ignores the variable, and after it the empty value keeps the default.Out of scope: the
nightly-testingrepository has its own variable namespace, so a flip there is a separate switch.publish_tools.ymlandcache_test.ymlrun no cache reads, so they stay unwired.