Skip to content

fix(Translate): apply (attr := ...) attributes in order of application time - #42765

Open
JovanGerb wants to merge 1 commit into
leanprover-community:masterfrom
JovanGerb:Jovan-translate-application_time
Open

fix(Translate): apply (attr := ...) attributes in order of application time#42765
JovanGerb wants to merge 1 commit into
leanprover-community:masterfrom
JovanGerb:Jovan-translate-application_time

Conversation

@JovanGerb

@JovanGerb JovanGerb commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

This PR sorts the (attr := ...) attributes in to_additive/to_dual so that they are applied in order of application time. This is consistent with the order in which attributes are applied by lean inside @[...] notation.

This is important because simps needs to run after implicit_reducible.


Open in Gitpod

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

PR summary 342b312c55

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ MyLE

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 342b312).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 342b312c55
Reference commit ae26804842

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-meta Tactics, attributes or user commands label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant