chore(GroupTheory): make smul_eq_self_of_mem_zpowers to_additive - #42764
chore(GroupTheory): make smul_eq_self_of_mem_zpowers to_additive#42764attilavjda wants to merge 1 commit into
smul_eq_self_of_mem_zpowers to_additive#42764Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary 4a7c367bdbImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type (strong) |
|---|---|---|
| 418 | -1 | porting notes |
Current commit 4a7c367bdb
Reference commit 4d476f6d44
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
| exact zpow_pow_orderOf | ||
|
|
||
| @[to_additive] | ||
| theorem smul_eq_self_of_mem_zpowers {α : Type*} [MulAction G α] (hx : x ∈ Subgroup.zpowers y) |
There was a problem hiding this comment.
I'm not sure if OrderOfElement is necessarily the right file for this anymore?
There was a problem hiding this comment.
moving it to a stabilizer or zpowers file would pull in an import, what do you think, maybe leave it?
Mathlib/GroupTheory/GroupAction/Basic.lean the stabilizer file needs only one extra import
|
Could you use backticks to make the title a bit easier to parse? e.g. |
smul_eq_self_of_mem_zpowers to_additive
6545ebc to
4a7c367
Compare
This PR makes
smul_eq_self_of_mem_zpowersamenable to@[to_additive]by reproving it via the action stabilizer andSubgroup.zpowers_le.This allows the additive counterpart to be generated automatically, removing the hand-written additive proof and the
to_additive existingworkaround.Used Aristotle AI to find this refactor and help write the proof.