Skip to content

chore(Algebra/BigOperators): add to_additive for expectation and antidiagonal lemmas - #42763

Open
attilavjda wants to merge 1 commit into
leanprover-community:masterfrom
attilavjda:chore/to-additive-antidiagonal-expect
Open

chore(Algebra/BigOperators): add to_additive for expectation and antidiagonal lemmas#42763
attilavjda wants to merge 1 commit into
leanprover-community:masterfrom
attilavjda:chore/to-additive-antidiagonal-expect

Conversation

@attilavjda

@attilavjda attilavjda commented Aug 14, 2026

Copy link
Copy Markdown
Contributor
  • Add @[to_additive] attributes to:

    • Expect.expect_inv_index
    • Nat.prod_antidiagonal_succ
    • Nat.prod_antidiagonal_succ'
  • Remove the duplicated additive proofs:

    • expect_neg_index
    • sum_antidiagonal_succ
    • sum_antidiagonal_succ'

Used Aristotle AI to find the duplicates, and verify the change, and ChatGPT, AmazonQ to navigate VS Code, cli, running tests, making the PR, understanding the proof and so forth


Open in Gitpod

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Aug 14, 2026
@github-actions

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

PR summary dce2e44302

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

- expect_neg_index
- sum_antidiagonal_succ
- sum_antidiagonal_succ'

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit dce2e44).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit dce2e44302
Reference commit 4d476f6d44

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Aug 14, 2026
@attilavjda
attilavjda force-pushed the chore/to-additive-antidiagonal-expect branch from 183455a to a5f6746 Compare August 14, 2026 09:54
Comment thread Mathlib/Algebra/BigOperators/Expect.lean Outdated
@attilavjda
attilavjda force-pushed the chore/to-additive-antidiagonal-expect branch from a5f6746 to 0e040bb Compare August 14, 2026 11:09
@attilavjda
attilavjda force-pushed the chore/to-additive-antidiagonal-expect branch from 0e040bb to dce2e44 Compare August 14, 2026 11:11

@themathqueen themathqueen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me, thanks!

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by themathqueen.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 14, 2026
@attilavjda

Copy link
Copy Markdown
Contributor Author

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants