Skip to content

feat(Topology): generalise IsometricSmul to WeakPseudoEMetricSpace and friends - #42750

Open
felixpernegger wants to merge 15 commits into
leanprover-community:masterfrom
felixpernegger:isometricsmulweak
Open

feat(Topology): generalise IsometricSmul to WeakPseudoEMetricSpace and friends#42750
felixpernegger wants to merge 15 commits into
leanprover-community:masterfrom
felixpernegger:isometricsmulweak

Conversation

@felixpernegger

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

PR summary 95dbb5a98c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ instance (priority := 100) IsIsometricSMul.opposite_of_comm [SMul M E] [SMul Mᵐᵒᵖ E]
+ instance (priority := 100) IsIsometricSMul.to_continuousConstSMul [SMul M P]
+ instance : EquivLike (X ≃ᵢ Y) X Y
+ instance : Group (X ≃ᵢ X)
+ instance : IsIsometricSMul M Wᵐᵒᵖ
+ instance : IsometryClass (IsometryEquiv X Y) X Y
+ instance {ι} {X : ι → Type*} [Fintype ι] [∀ i, SMul M (X i)] [∀ i, EDist (X i)]
++-- zero_iff
+-+- preimage_closedEBall
+-+- preimage_eball
+-+-+- edist_eq
- instance (priority := 100) IsIsometricSMul.opposite_of_comm [PseudoEMetricSpace X] [SMul M X]
- instance (priority := 100) IsIsometricSMul.to_continuousConstSMul [PseudoEMetricSpace X] [SMul M X]
- instance : EquivLike (α ≃ᵢ β) α β
- instance : Group (α ≃ᵢ α)
- instance : IsIsometricSMul M Xᵐᵒᵖ
- instance : IsometryClass (IsometryEquiv α β) α β
- instance {ι} {X : ι → Type*} [Fintype ι] [∀ i, SMul M (X i)] [∀ i, PseudoEMetricSpace (X i)]
-++- comp
-++- injective
-+-+ ediam_image
-+-+ ediam_range
-+-+-+ prodMk
-+--+++-+- continuous
--++ comp_continuousOn_iff
--++ comp_continuous_iff
--++ isUniformInducing
--++ prodMk_left
--++ prodMk_right
--++ uniformContinuous

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 95dbb5a).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


Increase in strong tech debt: (relative, absolute) = (1.00, 0.04)
Current number Change Type (strong)
25 1 disabled simpNF lints
No changes to weak technical debt.

Current commit 95dbb5a98c
Reference commit caa4dbde35

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@felixpernegger felixpernegger changed the title feat(Topology): generalise IsometricSmul to WeakPseudoEMetricSpace and friends feat(Topology): generalise IsometricSmul to WeakPseudoEMetricSpace and friends Aug 13, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 13, 2026
@mathlib-dependent-issues

Copy link
Copy Markdown

This PR/issue depends on:

simp only [dist, ← smul_Lp_neg, ← smul_Lp_add, norm_smul_Lp]

@[to_additive (attr := simp)]
@[to_additive (attr := simp, nolint simpNF)]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is a false positive, as the suggested simp makes no progress

@felixpernegger

Copy link
Copy Markdown
Contributor Author

LLM-generated

@github-actions github-actions Bot added the LLM-generated PRs with substantial input from LLMs - review accordingly label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) LLM-generated PRs with substantial input from LLMs - review accordingly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant