Skip to content

feat(RingTheory/Bialgebra): expose (Add)MonoidAlgebra.liftMulEquiv - #42749

Open
kim-em wants to merge 1 commit into
leanprover-community:masterfrom
kim-em:expose-liftMulEquiv
Open

feat(RingTheory/Bialgebra): expose (Add)MonoidAlgebra.liftMulEquiv#42749
kim-em wants to merge 1 commit into
leanprover-community:masterfrom
kim-em:expose-liftMulEquiv

Conversation

@kim-em

@kim-em kim-em commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

This PR marks MonoidAlgebra.liftMulEquiv and AddMonoidAlgebra.liftMulEquiv
@[expose, simps!], matching mapDomainBialgHomMulEquiv in the same file, which
is built the same way out of an equivalence composed with WithConv.equiv and
already carries both attributes. Without them the definitions are opaque
downstream: their bodies cannot be unfolded, and no lemma computes their
application or the application of their inverse, so liftMulEquiv cannot be
related to lift outside this file.

🤖 Prepared with Claude Code

This PR marks `MonoidAlgebra.liftMulEquiv` and `AddMonoidAlgebra.liftMulEquiv`
`@[expose, simps!]`, matching `mapDomainBialgHomMulEquiv` in the same file, which
is built the same way out of an equivalence composed with `WithConv.equiv` and
already carries both attributes. Without them the definitions are opaque
downstream: their bodies cannot be unfolded, and no lemma computes their
application or the application of their inverse, so `liftMulEquiv` cannot be
related to `lift` outside this file.

🤖 Prepared with Claude Code

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011nEb6EsLztScXUdX54Jd6V
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

PR summary 0a14478001

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 0a14478).

  • +4 new declarations
  • −0 removed declarations
+AddMonoidAlgebra.liftMulEquiv_apply_ofConv_apply
+AddMonoidAlgebra.liftMulEquiv_symm_apply_apply
+MonoidAlgebra.liftMulEquiv_apply_ofConv_apply
+MonoidAlgebra.liftMulEquiv_symm_apply_apply

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 0a14478001
Reference commit caa4dbde35

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-ring-theory Ring theory label Aug 13, 2026
@kim-em
kim-em marked this pull request as ready for review August 13, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant