Skip to content

[Merged by Bors] - chore(Data/Nat/GCD/Basic): automated extraction from #40597 - #42712

Closed
mathlib-splicebot[bot] wants to merge 1 commit into
masterfrom
splice-bot/pr-40597-Mathlib-Data-Nat-GCD-Basic.lean-d5a17e66e0-4kylmu6
Closed

[Merged by Bors] - chore(Data/Nat/GCD/Basic): automated extraction from #40597#42712
mathlib-splicebot[bot] wants to merge 1 commit into
masterfrom
splice-bot/pr-40597-Mathlib-Data-Nat-GCD-Basic.lean-d5a17e66e0-4kylmu6

Conversation

@mathlib-splicebot

Copy link
Copy Markdown
Contributor

This PR was automatically created from PR #40597 by @xroblot via a review comment by @tb65536.

@mathlib-splicebot

Copy link
Copy Markdown
Contributor Author

maintainer merge

Requested by @tb65536 via splice-bot from #40597.

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by tb65536 (via splice-bot from #40597).

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

PR summary fcbee48d36

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ div_dvd_div_iff_left
+ div_dvd_div_iff_right

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit fcbee48).

  • +2 new declarations
  • −0 removed declarations
+Nat.div_dvd_div_iff_left
+Nat.div_dvd_div_iff_right

No changes to strong technical debt.

No changes to weak technical debt.

Current commit fcbee48d36
Reference commit 130d6f7afe

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-data Data (lists, quotients, numbers, etc) label Aug 13, 2026

@jcommelin jcommelin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Aug 13, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 13, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Aug 13, 2026
This PR was automatically created from PR #40597 by @xroblot via a [review comment](#40597 (comment)) by @tb65536.

Co-authored-by: xroblot <46200072+xroblot@users.noreply.github.com>
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Aug 13, 2026
@mathlib-bors

mathlib-bors Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title chore(Data/Nat/GCD/Basic): automated extraction from #40597 [Merged by Bors] - chore(Data/Nat/GCD/Basic): automated extraction from #40597 Aug 13, 2026
@mathlib-bors mathlib-bors Bot closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants