feat(naming): update naming conventions for Prop-valued classes

[fpvandoorn]

Zulip

[grunweg]

Thanks for the PR! Can you link to a Zulip discussion or similar where this was discussed?

[fpvandoorn]

It was discussed in-person in Institute Pascal after I made this comment: leanprover-community/mathlib4#40552 (comment)
Do small changes documenting existing practice (i.e. not asking to do anything new) require a Zulip discussion? (assuming this counts as "small")

[grunweg]

Ah, I see. But we have plenty of past discussions on Prop-valued classes, right --- was this also mentioned there? I trust you to make reasonable proposals, but I think "two people discuss something in person" is not a good group process, sorry. A brief post on Zulip and waiting for 24h seems better.

[fpvandoorn]

Sure, I was happy to wait for a few thumb ups here. But I now also posted a public message in an existing thread, which was probably required to get enough eyes on this anyway.