chore: remove the defLemma linter#1863
Open
grunweg wants to merge 2 commits into
Open
Conversation
It has been upstreamed to Lean core (as the defProp linter), is enabled by default there --- so there is no need for the defLemma duplicating it.
github-actions
Bot
added
the
awaiting-review
Contributor
Author
|
I'm happy about input for fixing the test. I'm not sure what the first test is meant to test, so I cannot judge well if my fix is the right one. |
Contributor
|
Mathlib CI status (docs):
|
Contributor
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been upstreamed to Lean core (as the
defProplinter, see leanprover/lean4#13803) and is enabled by default (leanprover/lean4#13955) --- so there is no need for thedefLemmalinter duplicating it.