feat: isPrivateOrAutoDecl#1835
Open
thorimur wants to merge 7 commits into
Open
Conversation
github-actions
Bot
added
the
awaiting-review
1 task
Contributor
|
Mathlib CI status (docs):
|
mathlib-merge-conflicts
Bot
added
the
merge-conflict
mathlib-nightly-testing Bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jun 15, 2026
mathlib-nightly-testing Bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jun 15, 2026
Contributor
|
Mathlib CI status (docs):
|
mathlib-nightly-testing Bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jun 15, 2026
mathlib-merge-conflicts
Bot
removed
the
merge-conflict
Contributor
|
Mathlib CI status (docs):
|
Contributor
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
isPrivateOrAutoDeclin preparation for not returningtrueon private declarations inisAutoDecl(#1831). Currently, this has the same behavior asisAutoDecl; #1831 will modify the behavior ofisAutoDecl.It also (in preparation) modifies the docstring linters to use this declaration, since private declarations are allowed to not have docstrings.
As far as I can tell, the docstring linters are the only ones that are specifically about the public interface and would not also be helpful for private decls. Review should ensure that this is correct (for Batteries) :)