Add the prefer_equatable_mixin lint#503
Merged
PiotrRogulski merged 4 commits intomasterfrom Feb 26, 2026
Merged
Conversation
github-actions
bot
added
the
p: leancode_lint
There was a problem hiding this comment.
Pull request overview
Adds a new analyzer warning rule to the leancode_lint plugin that flags classes directly extending Equatable and recommends using EquatableMixin instead, including an automatic fix and accompanying documentation/tests.
Changes:
- Introduces the
prefer_equatable_mixinlint with an auto-fix (ConvertToEquatableMixin). - Registers the new rule + fix in the plugin and adds test coverage with an
equatablemock library. - Documents the new lint in the README and updates assist source links to
lib/src/assists/....
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/leancode_lint/lib/src/lints/prefer_equatable_mixin.dart | Implements the new lint and an automatic fix to convert extends Equatable to with EquatableMixin. |
| packages/leancode_lint/lib/plugin.dart | Registers the new warning rule and fix with the plugin registry. |
| packages/leancode_lint/test/test_cases/prefer_equatable_mixin_test.dart | Adds tests validating diagnostics for direct Equatable extension and no diagnostics for EquatableMixin. |
| packages/leancode_lint/test/mock_libraries/equatable.dart | Adds a mocked equatable package API for analyzer tests. |
| packages/leancode_lint/test/mock_libraries.dart | Wires the new equatable mock into the test harness via part. |
| packages/leancode_lint/README.md | Documents prefer_equatable_mixin and fixes assist file links to point at lib/src/assists. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Albert221
reviewed
Feb 23, 2026
packages/leancode_lint/lib/src/lints/prefer_equatable_mixin.dart
Outdated
Show resolved
Hide resolved
Albert221
reviewed
Feb 26, 2026
|
|
||
| None | ||
|
|
||
| ### `prefer_equatable_mixin` |
Member
There was a problem hiding this comment.
Explaining all lints in README takes much space. Maybe we could wrap them into <details>? Out of scope though
Albert221
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A partial reboot of #458 (I'll split it up into several PRs)