Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import 'dart:async';
import 'dart:convert';

import 'package:http/http.dart' as http;
import 'package:leancode_debug_page/src/models/log_gatherer.dart';
Expand Down Expand Up @@ -59,9 +60,10 @@ class LoggingHttpClient extends http.BaseClient

return http.StreamedResponse(
response.stream.doOnData(responseBodyBytes.addAll).doOnDone(() {
responseBodyCompleter.complete(
http.Response.bytes(responseBodyBytes, response.statusCode).body,
);
// Decode the response body using UTF-8 encoding to properly handle
// special characters like Polish letters (Ł, Ń, ą, etc.)
final responseBody = utf8.decode(responseBodyBytes, allowMalformed: true);
responseBodyCompleter.complete(responseBody);
}),
response.statusCode,
contentLength: response.contentLength,
Expand Down
39 changes: 39 additions & 0 deletions packages/leancode_debug_page/test/logging_http_client_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// clearly show all parameters being tested.
// ignore_for_file: avoid_redundant_argument_values

import 'dart:convert';

import 'package:flutter_test/flutter_test.dart';
import 'package:http/http.dart';
import 'package:leancode_debug_page/src/core/logging_http_client.dart';
Expand Down Expand Up @@ -96,6 +98,43 @@ void main() {
);
},
);

test(
'properly decodes UTF-8 characters including Polish letters',
() async {
const polishText = 'Autoryzacja nie została wykonana. Łódź, Gdańsk, Kraków.';
final polishBytes = utf8.encode(polishText);
final streamWithPolishText = Stream.fromIterable([polishBytes]);

when<Future<StreamedResponse>>(() => mockHttpClient.send(any()))
.thenAnswer(
(invocation) async => StreamedResponse(
streamWithPolishText,
statusCode,
contentLength: polishBytes.length,
request: request,
headers: headers,
isRedirect: isRedirect,
persistentConnection: persistentConnection,
reasonPhrase: reasonPhrase,
),
);

await loggingHttpClient.send(request);

// Wait for the response body to be completed
await Future.delayed(const Duration(milliseconds: 100));

expect(loggingHttpClient.logs, hasLength(1));
final log = loggingHttpClient.logs.first;
final responseBody = await log.responseBodyCompleter.future;

expect(responseBody, contains('Autoryzacja'));
expect(responseBody, contains('Łódź'));
expect(responseBody, contains('Gdańsk'));
expect(responseBody, contains('Kraków'));
},
);
},
);
}