Skip to content

chore: update minimum Rust version from 1.96.0 to 1.97.0 - #29

Merged
jsonbailey merged 1 commit into
mainfrom
devin/1791795901-msrv-1.97
Oct 12, 2026
Merged

jsonbailey merged 1 commit into
mainfrom
devin/1791795901-msrv-1.97

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This raises the example's MSRV to 1.97.0, because the daily Build and run on main has been red since 2026-10-08.

  • launchdarkly-server-sdk 3.3.0 (latest; >=3.1.1 already resolves to it) depends on eventsource-client ^0.18.0. eventsource-client 0.18.1, published 2026-10-07, declares rust-version = "1.97.0".
  • On rustc 1.96.0, cargo fails with: eventsource-client@0.18.1 requires rustc 1.97.0.
  • The SDK made the same MSRV change upstream (fix: Bump MSRV from 1.96 to 1.97 rust-server-sdk#204, "fix: Bump MSRV from 1.96 to 1.97"). That will ship in the pending 3.3.1 release.
  • Cargo.toml changes rust-version from 1.96.0 to 1.97.0, and ci.yml changes rustup override set from 1.96.0 to 1.97.0. Nothing else changes; the SDK constraint stays as it is.
Verification

Local, on rustc 1.97.0:

  • cargo clippy with RUSTFLAGS="-W deprecated" produced no warnings.
  • LAUNCHDARKLY_SDK_KEY=… LAUNCHDARKLY_FLAG_KEY=hello-boolean CI=1 cargo run -q printed:
*** SDK successfully initialized.
*** The hello-boolean feature flag evaluates to true

and then the banner.

On rustc 1.96.0 the build fails with the same error as the scheduled CI runs (e.g. run 38127323604).

The inbox_rx is disconnected ERROR log at shutdown is not new: the last green run on 2026-10-07 shows it too.

Link to Devin session: https://app.devin.ai/sessions/738ced6178134242807e7d6c7f0c27e3
Open in Devin Desktop: https://app.devin.ai/desktop/session/738ced6178134242807e7d6c7f0c27e3?variant=devin


Note

Overview
Raises the project minimum supported Rust version from 1.96.0 to 1.97.0 in Cargo.toml and aligns the Build and run workflow so rustup override set uses 1.97.0.

This unblocks CI and local builds where launchdarkly-server-sdk (via eventsource-client 0.18.1) now requires rustc 1.97.0. Dependency constraints are unchanged.

Reviewed by Cursor Bugbot for commit 6abb8ca. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

@cursor review

@kinyoklion
kinyoklion marked this pull request as ready for review October 12, 2026 17:40
@kinyoklion
kinyoklion requested a review from a team as a code owner October 12, 2026 17:40

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low. Approved. Cursor Bugbot and Cursor Security Agent both passed with no findings, and this is a two-line MSRV/CI toolchain bump with no behavior or security changes.

Open in Web View Automation 

Sent by Cursor Approval Agent: SDK - Pull Request Router and Approver

@jsonbailey jsonbailey changed the title fix: update minimum Rust version from 1.96.0 to 1.97.0 chore: update minimum Rust version from 1.96.0 to 1.97.0 Oct 12, 2026
@jsonbailey
jsonbailey merged commit c1ba460 into main Oct 12, 2026
7 checks passed
@jsonbailey
jsonbailey deleted the devin/1791795901-msrv-1.97 branch October 12, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants