[FIX] Math and Std not being avaliable for static functions
#265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotHyper-474
changed the title
Math and Std not being avaliable in a static contextMath and Std not being avaliable for static functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge of #247 introduced a bug where trying to access either of those classes in a static function would cause a missing import error, this is because it causes the static interpreter's variables to get reset to HScript's defaults.
The fix here involves removing the definition from the Interp's constructor and instead making those default imports.
It should be noted that this would not fix the issue for static local functions because those lose their context, which #209 fixes.