[2.x] Fix workflow YAML syntax and remove no-op composer require - #291
Merged
Merged
Conversation
- Quote *.x branch pattern — unquoted * is reserved in YAML, causing the workflow to fail on every push to versioned branches - Remove empty composer require with no package name, which caused every CI job to fail with "Not enough arguments"
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The tests workflow has been broken since 2026-02-20 when PR #289 (Laravel 13.x Compatibility) accidentally unquoted the
'*.x'branch pattern. Every test run since then has been instantly rejected by GitHub Actions — 5 weeks of no CI coverage.Root cause
The L13 compatibility PR changed
'*.x'to*.xin thebrancheslist. In YAML,*is a reserved character (alias node indicator), causing GitHub Actions to reject the workflow file. The quotes were correct before and got removed during the edit.Fix
*.xto'*.x'— restores the branch pattern that was working before PR Laravel 13.x Compatibility #289composer require --no-updateline — this has been in the workflow for a while with no package argument. Composer silently ignores it (exits 0), so it's not causing failures, but it's dead code that looks like a bug.CI result
All 30/30 matrix jobs pass — PHP 7.2–8.4 × Laravel 6–13.