implement pinning functionality (#3)#538
Open
brotherdetjr wants to merge 1 commit intolanoxx:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Sebastian,
Thanks for merging my copy-on-select PR! Here's another change I'd like to suggest (honestly, I don't have more :) ).
I find the existing auto-hide experience very smooth and handy. However, every now and then I need to temporarily switch it off, e.g. when I want to keep Tilda window visible and check smth in another one. I though it would be nice to have a "pinning" functionality, which gives you a quick way of disabling auto-hide and re-enabling it back.
That's what this PR is about.
Initially I was going to draw a pin overlaying the main window. In most cases it would work, but not when the main window has something important in the top-left corner. The first thought was to allow a user to configure in which corner the pin should appear, but I ended up with drawing a dedicated panel for the pin at the top of the window, similarly to search panel. So the main window's content is never overlapped.
I tested this feature in multiple configurations: different auto-hide combinations, fullscreen, desktop window, tabs on top, at the bottom, on the left, on the right, etc... Seems working reasonably well to me. Though have to say, I've got only Linux Mint 22.2 Cinnamon on my machine with its window manager, and Tilda is supposed to run in different envs, which I haven't tested yet. Though I assume the change is still rather safe.
If you could check the change and provide some feedback, would be amazing (assuming you accept the idea of pinning itself)!
Cheers,
Denis