Improve typings for message stream events#8
Merged
Conversation
Member
|
Hey @tifilipebr, thanks for the PR! I am just confirming with the Langflow team that the Will get back to you soon. |
Contributor
Author
|
Hi Phil, that’s great! I defined these types based on some responses I observed during usage, but I agree it would be important to confirm against the specifications to ensure consistency for consumers. Thanks for the attention and the reply, and I hope we can keep improving the typings. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
MessageStreamEventDatainterface and updates theAddMessageStreamEventtype to use this interface instead ofunknown.This improves TypeScript typing for message stream events, making the code safer and easier to work with.
Changes
MessageStreamEventDatainterface intypes.ts.unknownwithMessageStreamEventDatain theAddMessageStreamEventtype.Motivation
Enhances type safety and developer experience by providing proper typings for streamed messages.
Checklist
All steps from the contributing guide have been completed:
npm install)npm test)npm run build)npm run lint)npm run format/npm run format:check)