Skip to content

Conversation

@fangbo
Copy link
Contributor

@fangbo fangbo commented Oct 31, 2025

This is for #101

@github-actions github-actions bot added the enhancement New feature or request label Oct 31, 2025
@fangbo
Copy link
Contributor Author

fangbo commented Oct 31, 2025

@jackye1995 This PR is ready. Could you please review it ? Thank you.

statement
: ALTER TABLE multipartIdentifier ADD COLUMNS columnList FROM identifier #addColumnsBackfill
: ALTER TABLE multipartIdentifier ADD COLUMNS columnList FROM identifier #addColumnsBackfill
| ALTER TABLE multipartIdentifier COMPACT (WITH '(' (namedArgument (',' namedArgument)*)? ')')? #compact
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for compaction we should use the syntax similar to Delta: https://docs.databricks.com/aws/en/sql/language-manual/delta-optimize

Given our roadmap to also support features like liquid clustering and z-order compaction.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your advice. I refactor the grammar and use OPTIMIZE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackye1995 This PR is ready. Could you please review it again? Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants