feat: Support DELETE operation on Lance datasets#19
Open
fightBoxing wants to merge 1 commit intomainfrom
Open
Conversation
- Add LanceDeleteExecutor for predicate-based row deletion - Update LanceSink to handle DELETE RowKind with buffered batch processing - Update LanceDynamicTableSink to support DELETE in ChangelogMode - Build delete predicates from RowData fields (supports common types) - Add comprehensive unit tests for DELETE functionality - Inspired by lance-spark DELETE implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements DELETE support for Lance datasets, addressing #8.
Inspired by the lance-spark DELETE implementation, this PR adds predicate-based row deletion using Lance SDK's native
Dataset.delete(String predicate)method.Changes
New Files
LanceDeleteExecutor: Standalone executor class that wraps Lance SDK'sDataset.delete()methoddelete(),deleteAndCount(), andcountRows()methodsCloseablefor proper resource managementModified Files
LanceSink: Enhanced to handle DELETE RowKindLanceDynamicTableSink: Updated ChangelogMode to support DELETE when requestedHow DELETE Works
When a
RowDatawithRowKind.DELETEis received:(id=1, name='Alice')and(id=2, name='Bob'):Dataset.delete(predicate)Usage Example
Standalone DELETE:
Testing
Closes #8