Skip to content

Conversation

@iovoid
Copy link
Contributor

@iovoid iovoid commented Dec 1, 2025

Motivation

In preparation for paralellization of storage merkelization, we want to remove the data dependency of storages on the current account state.

Description

Reads the root from the database when opening the trie.

@github-actions github-actions bot added the L1 Ethereum client label Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Lines of code report

Total lines added: 12
Total lines removed: 0
Total lines changed: 12

Detailed view
+----------------------------------------+-------+------+
| File                                   | Lines | Diff |
+----------------------------------------+-------+------+
| ethrex/crates/blockchain/blockchain.rs | 1519  | +3   |
+----------------------------------------+-------+------+
| ethrex/crates/common/trie/trie.rs      | 987   | +9   |
+----------------------------------------+-------+------+

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Benchmark for 460db6e

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 30.0±1.64ms 31.0±2.34ms +3.33%
Trie/cita-trie insert 1k 2.9±0.03ms 2.9±0.13ms 0.00%
Trie/ethrex-trie insert 10k 25.6±0.85ms 27.7±1.07ms +8.20%
Trie/ethrex-trie insert 1k 2.2±0.01ms 2.2±0.03ms 0.00%

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Benchmark for ab77796

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 29.1±0.88ms 30.8±1.89ms +5.84%
Trie/cita-trie insert 1k 2.7±0.02ms 2.7±0.11ms 0.00%
Trie/ethrex-trie insert 10k 25.8±0.95ms 26.5±1.24ms +2.71%
Trie/ethrex-trie insert 1k 2.2±0.01ms 2.2±0.01ms 0.00%

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Benchmark for 0009717

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 29.0±1.28ms 29.1±0.94ms +0.34%
Trie/cita-trie insert 1k 2.8±0.04ms 2.8±0.01ms 0.00%
Trie/ethrex-trie insert 10k 25.5±1.52ms 26.0±1.40ms +1.96%
Trie/ethrex-trie insert 1k 2.2±0.02ms 2.2±0.10ms 0.00%

@iovoid iovoid marked this pull request as ready for review December 2, 2025 14:06
@iovoid iovoid requested a review from a team as a code owner December 2, 2025 14:06
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants