Skip to content

fix(l2): Fix EIP-4844 blob fee bump to use percentage scale #5415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(l2): Fix EIP-4844 blob fee bump to use percentage scale #5415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/l2/sdk/src/sdk.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,10 +813,10 @@ fn bump_gas_generic_tx(tx: &mut GenericTransaction, bump_percentage: u64) {
*max_priority_fee_per_gas = (*max_priority_fee_per_gas * (100 + bump_percentage)) / 100;
}
if let Some(max_fee_per_blob_gas) = &mut tx.max_fee_per_blob_gas {
let factor = 1 + (bump_percentage / 100) * 10;
let factor = 100 + bump_percentage;
*max_fee_per_blob_gas = max_fee_per_blob_gas
.saturating_mul(U256::from(factor))
.div(10);
.div(100);
Comment on lines 815 to +819
Copy link
Contributor

@Oppen Oppen Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep the same semantics without the integer truncation issue what you actually need is:

Suggested change
if let Some(max_fee_per_blob_gas) = &mut tx.max_fee_per_blob_gas {
let factor = 1 + (bump_percentage / 100) * 10;
let factor = 100 + bump_percentage;
*max_fee_per_blob_gas = max_fee_per_blob_gas
.saturating_mul(U256::from(factor))
.div(10);
.div(100);
if let Some(max_fee_per_blob_gas) = &mut tx.max_fee_per_blob_gas {
let factor = 100 + bump_percentage * 10;
*max_fee_per_blob_gas = max_fee_per_blob_gas
.saturating_mul(U256::from(factor))
.div(1000);

I don't know why the magic multiply and divide by 10 was there, but if there was a reason you'll want to keep it.

}
}

Expand Down
Loading