chore(l1): add rlp encode benches #5413

edg-l · 2025-11-25T08:58:15Z

Adds the encoding benches for rlp

Part of #5411

github-actions · 2025-11-25T09:01:10Z

Lines of code report

Total lines added: 1288
Total lines removed: 0
Total lines changed: 1288

Detailed view

+--------------------------------------------+-------+-------+
| File                                       | Lines | Diff  |
+--------------------------------------------+-------+-------+
| ethrex/crates/common/rlp/benches/decode.rs | 30    | +30   |
+--------------------------------------------+-------+-------+
| ethrex/crates/common/rlp/benches/encode.rs | 1258  | +1258 |
+--------------------------------------------+-------+-------+

crates/common/rlp/benches/encode.rs

Oppen · 2025-11-26T13:12:06Z

crates/common/rlp/benches/encode.rs

I think we should aim at keeping benches in benches subdir. I know a few of them are in other places (and I'm guilty of a few), but keeping crates free from this code would reduce noise in the day to day work and save us from overestimating our line count (assuming we only care about the code that implements functionality, rather than code that measures its performance or tests it).

@mpaulucci @Arkenan wdyt?

I don't mind either way, but we should be consitent. If we go for the top level benches lets create a ticket to move all benches there

github-actions · 2025-12-01T11:22:10Z

RLP Bench Results

Bench output

basic_types/encode_int_list_len_10
----------------------------------
base     1.00      58.6±1.43ns  162.8 MElem/sec
new      1.00      58.6±1.43ns  162.8 MElem/sec

basic_types/encode_int_list_len_100
-----------------------------------
base     1.00     566.4±8.04ns  168.4 MElem/sec
new      1.00     566.4±8.04ns  168.4 MElem/sec

basic_types/encode_int_list_len_1000
------------------------------------
base     1.00       5.5±0.05µs  173.3 MElem/sec
new      1.00       5.5±0.05µs  173.3 MElem/sec

basic_types/encode_string_len_5
-------------------------------
base     1.00      44.8±0.46µs  212.9 MElem/sec
new      1.00      44.8±0.46µs  212.9 MElem/sec

basic_types/encode_string_len_500
---------------------------------
base     1.00   1201.2±74.08µs  7.9 MElem/sec
new      1.00   1201.2±74.08µs  7.9 MElem/sec

basic_types/encode_string_len_60
--------------------------------
base     1.00     121.9±3.03µs  78.2 MElem/sec
new      1.00     121.9±3.03µs  78.2 MElem/sec

basic_types/encode_string_list_len_10
-------------------------------------
base     1.00      67.5±3.19ns  141.3 MElem/sec
new      1.00      67.5±3.19ns  141.3 MElem/sec

basic_types/encode_string_list_len_100
--------------------------------------
base     1.00     537.8±8.79ns  177.3 MElem/sec
new      1.00     537.8±8.79ns  177.3 MElem/sec

basic_types/encode_string_list_len_1000
---------------------------------------
base     1.00       5.2±0.09µs  184.4 MElem/sec
new      1.00       5.2±0.09µs  184.4 MElem/sec

basic_types/encode_u128_random_seeded
-------------------------------------
base     1.00       7.1±0.01ms  134.4 MElem/sec
new      1.00       7.1±0.01ms  134.4 MElem/sec

basic_types/encode_u16_random_seeded
------------------------------------
base     1.00       4.7±0.07ms  205.0 MElem/sec
new      1.00       4.7±0.07ms  205.0 MElem/sec

basic_types/encode_u256_random_seeded
-------------------------------------
base     1.00       5.6±0.07ms  171.3 MElem/sec
new      1.00       5.6±0.07ms  171.3 MElem/sec

basic_types/encode_u32_random_seeded
------------------------------------
base     1.00       5.0±0.02ms  190.5 MElem/sec
new      1.00       5.0±0.02ms  190.5 MElem/sec

basic_types/encode_u64_random_seeded
------------------------------------
base     1.00       4.9±0.02ms  196.4 MElem/sec
new      1.00       4.9±0.02ms  196.4 MElem/sec

basic_types/encode_u8_random_seeded
-----------------------------------
base     1.00    1345.8±1.82µs  708.6 MElem/sec
new      1.00    1345.8±1.82µs  708.6 MElem/sec

common_types/encode_account_info
--------------------------------
base     1.00     116.4±3.93ns  8.2 MElem/sec
new      1.00     116.4±3.93ns  8.2 MElem/sec

common_types/encode_account_state
---------------------------------
base     1.00     135.4±4.96ns  7.0 MElem/sec
new      1.00     135.4±4.96ns  7.0 MElem/sec

common_types/encode_blobs_bundle
--------------------------------
base     1.00      94.1±0.59µs  10.4 KElem/sec
new      1.00      94.1±0.59µs  10.4 KElem/sec

common_types/encode_block
-------------------------
base     1.00       6.3±0.18µs  155.5 KElem/sec
new      1.00       6.3±0.18µs  155.5 KElem/sec

common_types/encode_block_header
--------------------------------
base     1.00    550.0±17.88ns  1775.7 KElem/sec
new      1.00    550.0±17.88ns  1775.7 KElem/sec

common_types/encode_encoded_requests
------------------------------------
base     1.00      18.0±1.34ns  53.1 MElem/sec
new      1.00      18.0±1.34ns  53.1 MElem/sec

common_types/encode_fork_id
---------------------------
base     1.00      63.9±2.30ns  14.9 MElem/sec
new      1.00      63.9±2.30ns  14.9 MElem/sec

common_types/encode_log
-----------------------
base     1.00     231.3±7.94ns  4.1 MElem/sec
new      1.00     231.3±7.94ns  4.1 MElem/sec

common_types/encode_receipt
---------------------------
base     1.00   1103.0±23.76ns  885.4 KElem/sec
new      1.00   1103.0±23.76ns  885.4 KElem/sec

common_types/encode_receipt_with_bloom
--------------------------------------
base     1.00   1198.0±15.16ns  815.2 KElem/sec
new      1.00   1198.0±15.16ns  815.2 KElem/sec

common_types/encode_withdrawals
-------------------------------
base     1.00     117.9±5.79ns  8.1 MElem/sec
new      1.00     117.9±5.79ns  8.1 MElem/sec

networking_p2p/encode_account_range_unit
----------------------------------------
base     1.00     269.4±9.48ns  3.5 MElem/sec
new      1.00     269.4±9.48ns  3.5 MElem/sec

networking_p2p/encode_account_state_slim
----------------------------------------
base     1.00     155.7±2.47ns  6.1 MElem/sec
new      1.00     155.7±2.47ns  6.1 MElem/sec

networking_p2p/encode_capability
--------------------------------
base     1.00      36.4±1.30ns  26.2 MElem/sec
new      1.00      36.4±1.30ns  26.2 MElem/sec

networking_p2p/encode_endpoint
------------------------------
base     1.00      60.8±3.17ns  15.7 MElem/sec
new      1.00      60.8±3.17ns  15.7 MElem/sec

networking_p2p/encode_enr_request_message
-----------------------------------------
base     1.00      38.2±2.55ns  25.0 MElem/sec
new      1.00      38.2±2.55ns  25.0 MElem/sec

networking_p2p/encode_find_node_message
---------------------------------------
base     1.00     127.9±2.98ns  7.5 MElem/sec
new      1.00     127.9±2.98ns  7.5 MElem/sec

networking_p2p/encode_neighbors_message
---------------------------------------
base     1.00    605.0±12.69ns  1614.0 KElem/sec
new      1.00    605.0±12.69ns  1614.0 KElem/sec

networking_p2p/encode_node
--------------------------
base     1.00     114.1±3.26ns  8.4 MElem/sec
new      1.00     114.1±3.26ns  8.4 MElem/sec

networking_p2p/encode_node_record
---------------------------------
base     1.00     226.9±2.65ns  4.2 MElem/sec
new      1.00     226.9±2.65ns  4.2 MElem/sec

networking_p2p/encode_ping_message
----------------------------------
base     1.00     221.7±4.89ns  4.3 MElem/sec
new      1.00     221.7±4.89ns  4.3 MElem/sec

networking_p2p/encode_storage_slot
----------------------------------
base     1.00     120.3±3.51ns  7.9 MElem/sec
new      1.00     120.3±3.51ns  7.9 MElem/sec

transactions/encode_call
------------------------
base     1.00       3.7±0.01ns  255.6 MElem/sec
new      1.00       3.7±0.01ns  255.6 MElem/sec

transactions/encode_create
--------------------------
base     1.00       2.2±0.02ns  434.4 MElem/sec
new      1.00       2.2±0.02ns  434.4 MElem/sec

transactions/encode_eip1559_transaction
---------------------------------------
base     1.00    358.9±11.18ns  2.7 MElem/sec
new      1.00    358.9±11.18ns  2.7 MElem/sec

transactions/encode_eip2930_transaction
---------------------------------------
base     1.00     353.4±9.67ns  2.7 MElem/sec
new      1.00     353.4±9.67ns  2.7 MElem/sec

transactions/encode_eip4844_transaction
---------------------------------------
base     1.00    413.4±13.93ns  2.3 MElem/sec
new      1.00    413.4±13.93ns  2.3 MElem/sec

transactions/encode_eip7702_transaction
---------------------------------------
base     1.00    647.9±17.01ns  1507.3 KElem/sec
new      1.00    647.9±17.01ns  1507.3 KElem/sec

transactions/encode_fee_token_transaction
-----------------------------------------
base     1.00    417.9±11.72ns  2.3 MElem/sec
new      1.00    417.9±11.72ns  2.3 MElem/sec

transactions/encode_legacy_transaction
--------------------------------------
base     1.00     159.1±9.50ns  6.0 MElem/sec
new      1.00     159.1±9.50ns  6.0 MElem/sec

transactions/encode_mempool_transaction
---------------------------------------
base     1.00    518.9±10.22ns  1882.0 KElem/sec
new      1.00    518.9±10.22ns  1882.0 KElem/sec

transactions/encode_p2p_transaction
-----------------------------------
base     1.00      11.3±0.12µs  86.5 KElem/sec
new      1.00      11.3±0.12µs  86.5 KElem/sec

transactions/encode_privileged_l2_transaction
---------------------------------------------
base     1.00    373.1±14.06ns  2.6 MElem/sec
new      1.00    373.1±14.06ns  2.6 MElem/sec

transactions/encode_wrapped_eip4844_transaction
-----------------------------------------------
base     1.00      17.3±0.11µs  56.5 KElem/sec
new      1.00      17.3±0.11µs  56.5 KElem/sec

trie/encode_branch_node
-----------------------
base     1.00      88.7±2.28ns  10.8 MElem/sec
new      1.00      88.7±2.28ns  10.8 MElem/sec

trie/encode_extension_node
--------------------------
base     1.00     121.2±2.22ns  7.9 MElem/sec
new      1.00     121.2±2.22ns  7.9 MElem/sec

trie/encode_leaf_node
---------------------
base     1.00     115.7±1.44ns  8.2 MElem/sec
new      1.00     115.7±1.44ns  8.2 MElem/sec

trie/encode_nibbles_len_129
---------------------------
base     1.00    469.8±14.03ns  2.0 MElem/sec
new      1.00    469.8±14.03ns  2.0 MElem/sec

trie/encode_nibbles_len_130
---------------------------
base     1.00     473.5±8.23ns  2.0 MElem/sec
new      1.00     473.5±8.23ns  2.0 MElem/sec

trie/encode_nibbles_len_500
---------------------------
base     1.00   1231.9±10.02ns  792.7 KElem/sec
new      1.00   1231.9±10.02ns  792.7 KElem/sec

trie/encode_nibbles_len_65
--------------------------
base     1.00     310.5±6.26ns  3.1 MElem/sec
new      1.00     310.5±6.26ns  3.1 MElem/sec

trie/encode_node_hash_hashed
----------------------------
base     1.00      68.1±3.41ns  14.0 MElem/sec
new      1.00      68.1±3.41ns  14.0 MElem/sec

trie/encode_node_hash_inline
----------------------------
base     1.00      45.6±4.05ns  20.9 MElem/sec
new      1.00      45.6±4.05ns  20.9 MElem/sec

edg-l added 6 commits November 24, 2025 14:31

base pr to add rlp benches

8d8a285

bench skeleton

e84c627

initial

3abca00

account info

2a9815e

more

d69c78c

more benches

ebbb589

github-actions bot assigned edg-l Nov 25, 2025

github-actions bot added the L1 Ethereum client label Nov 25, 2025

github-project-automation bot added this to ethrex_l1 Nov 25, 2025

edg-l added 8 commits November 25, 2025 10:10

transaction benches

e619509

more

1c51068

improve

36ae05e

black boxed

82a5c6e

better

b636482

trie benches

6e1c623

benches

88ba9fa

labels

73c313b

edg-l marked this pull request as ready for review November 26, 2025 08:43

edg-l requested a review from a team as a code owner November 26, 2025 08:43

ethrex-project-sync bot moved this to In Review in ethrex_l1 Nov 26, 2025

Oppen reviewed Nov 26, 2025

View reviewed changes

crates/common/rlp/benches/encode.rs Outdated Show resolved Hide resolved

Oppen reviewed Nov 26, 2025

View reviewed changes

crates/common/rlp/benches/encode.rs Show resolved Hide resolved

Oppen reviewed Nov 26, 2025

View reviewed changes

Oppen approved these changes Nov 26, 2025

View reviewed changes

edg-l added 5 commits November 26, 2025 16:24

fix int list

3d8158c

with capacity

680dbb0

with capacity

fcd592f

improve criterion config

5561c7b

label

604c0b8

add throughput

058ba74

edg-l changed the base branch from rlp_benches_base to main November 28, 2025 07:21

edg-l added 4 commits November 28, 2025 08:22

Merge remote-tracking branch 'origin/main' into rlp_benches_encode

a49f3ab

ci

cb0e5ae

continue

00ce31e

ci

0b34cb1

edg-l added 2 commits December 1, 2025 12:47

summary

062670d

Merge branch 'main' into rlp_benches_encode

05036b7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(l1): add rlp encode benches #5413

chore(l1): add rlp encode benches #5413

Uh oh!

edg-l commented Nov 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 25, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Oppen Nov 26, 2025

Uh oh!

Oppen Nov 26, 2025

Uh oh!

mpaulucci Dec 2, 2025

Uh oh!

github-actions bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chore(l1): add rlp encode benches #5413

Are you sure you want to change the base?

chore(l1): add rlp encode benches #5413

Uh oh!

Conversation

edg-l commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lines of code report

Uh oh!

Uh oh!

Uh oh!

Oppen Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Oppen Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

mpaulucci Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

RLP Bench Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

edg-l commented Nov 25, 2025 •

edited

Loading

github-actions bot commented Nov 25, 2025 •

edited

Loading

github-actions bot commented Dec 1, 2025 •

edited

Loading