Skip to content

chore(l2): optimize node decoding #4808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

chore(l2): optimize node decoding #4808

wants to merge 2 commits into from

Conversation

@xqft
Copy link
Contributor

@xqft xqft commented Oct 8, 2025

Motivation

Description

Closes #issue_number

@github-actions github-actions bot added the L2 Rollup client label Oct 8, 2025
@xqft xqft changed the title chore(l2): use SP1 patch for ecpairing precompile chore(l2): optimize node decoding Oct 8, 2025
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Lines of code report

Total lines added: 2
Total lines removed: 0
Total lines changed: 2

Detailed view 
+-----------------------------------+-------+------+
| File                              | Lines | Diff |
+-----------------------------------+-------+------+
| ethrex/crates/common/trie/node.rs | 245   | +2   |
+-----------------------------------+-------+------+

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Benchmark for cf2b4e1

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 33.3±1.38ms 38.4±2.04ms +15.32%
Trie/cita-trie insert 1k 3.5±0.04ms 3.7±0.24ms +5.71%
Trie/ethrex-trie insert 10k 58.7±2.74ms 56.9±1.13ms -3.07%
Trie/ethrex-trie insert 1k 6.1±0.03ms 6.2±0.09ms +1.64%

@xqft
Copy link
Contributor Author

xqft commented Oct 17, 2025

superseded by #4928

@xqft xqft closed this Oct 17, 2025
@MegaRedHand MegaRedHand deleted the opt_node_decoding branch October 17, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@xqft xqft

Labels

L2 Rollup client

Projects

ethrex_l2
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xqft