feat(l1): make the database path-based #4806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 175de2d.
Benchmark for 956ca77Click to view benchmark
|
Benchmark for dad1d71Click to view benchmark
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Benchmark for 17a5540Click to view benchmark
|
Benchmark for 5bfd315Click to view benchmark
|
mpaulucci
reviewed
Oct 15, 2025
mpaulucci
reviewed
Oct 15, 2025
| // Insert into self | ||
| self.update(value); | ||
| } else { | ||
| // Value in branches don't happen in our use-case. |
Collaborator
There was a problem hiding this comment.
then below it should be unreachable!?
Collaborator
There was a problem hiding this comment.
It can't happen in our use-case, but a user of ethrex-trie can still trigger this. We should first decide if we want to support this use-case: if we don't want to, then we can mark it as unreachable! and add a couple of checks to avoid reaching this branch, or we can add an unimplemented!, but we should document the lack of support for values in branches. I think leaving it as todo! for now would also be OK.
**Motivation** Fixes devp2p tests on the path based branch **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #issue_number --------- Co-authored-by: Tomás Grüner <[email protected]>
Benchmark for 0511e66Click to view benchmark
|
Benchmark for bc689a9Click to view benchmark
|
Benchmark for 1fefeeaClick to view benchmark
|
Benchmark for 1afccbdClick to view benchmark
|
Benchmark for 9dd9887Click to view benchmark
|
Benchmark for 74f907dClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want a path-based database:
Description
Support for "archive mode" (keeping indefinitely old state) is dropped.
To handle reorgs we use in-memory layers that exist on top of the db.