fix(Discord): Unfuck Discord rpc#279
Open
IceTank wants to merge 2 commits intolambda-client:1.21.11from
Open
Conversation
beanbag44
requested changes
Mar 25, 2026
| if (rpc == null) { | ||
| rpc = KDiscordIPC(Lambda.APP_ID, scope = EventFlow.lambdaScope) | ||
| } | ||
| if (rpc!!.connected) return true |
Member
There was a problem hiding this comment.
we, if not never, almost never use !! as it voids kotlins null safety checks and opens space up for null pointer exceptions
|
|
||
| onEnable { runConcurrent { start(); handleLoop() } } | ||
| runConcurrent { start() } | ||
| onEnable { |
Member
There was a problem hiding this comment.
this is the only place start() is called which will not run if the user has the module enabled on client startup as onEnable requires a SafeContext
| private val line2Right by setting("Line 2 Right", LineInfo.Fps) | ||
|
|
||
| val rpc = KDiscordIPC(Lambda.APP_ID, scope = EventFlow.lambdaScope) | ||
| var rpc: KDiscordIPC? = null |
Member
There was a problem hiding this comment.
could this be replaced with a lazy {}?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change lazy loads the Discord integration dependency, removing around a 10-second unavoidable delay when starting the game.
This also fixes the module starting the Discord RPC integration even if the module is disabled.