This repository was archived by the owner on Oct 10, 2025. It is now read-only.
Repository navigation
Support SET with dictionary - #5996
Merged
Merged
Conversation
Benchmark ResultMaster commit hash:
Other queries
|
andyfengHKU
approved these changes
Sep 10, 2025
andyfengHKU
left a comment
andyfengHKU
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM just need more testing.
| for (auto& setItem : ctx.oC_SetItem()) { | ||
| setClause->addSetItem(transformSetItem(*setItem)); | ||
| if (ctx.kU_Properties()) { | ||
| KU_ASSERT(ctx.kU_Properties()->oC_PropertyKeyName().size() == |
Contributor
There was a problem hiding this comment.
No need to assert. This is guaranteed by the grammar.
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5996 +/- ##
=======================================
Coverage 86.32% 86.33%
=======================================
Files 1456 1456
Lines 65790 65802 +12
Branches 8029 8031 +2
=======================================
+ Hits 56793 56807 +14
+ Misses 8739 8736 -3
- Partials 258 259 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hakuuww
pushed a commit
that referenced
this pull request
Sep 12, 2025
* Test for multiple set support * Implement SET by dictionary + basic tests * ci: auto code format * write analogous tests for SET by dict to existing SET tests --------- Co-authored-by: CI Bot <carminite@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supports the following syntax:
MATCH (n) SET n = $datawhere$datais a dict containing property keys and values.NOTE that only property keys are allowed, not property expressions (like
a.*). Nor are multiple assignments allowed (likeSET n = { ... }, m = { ... }orSET n.var = val, m = { ... })Associated docs (issue or PR):
Contributor agreement