This repository was archived by the owner on Oct 10, 2025. It is now read-only.
Repository navigation
Rework parameter handling - #5990
Merged
Merged
Conversation
andyfengHKU
force-pushed
the
issue-5937
branch
from
September 9, 2025 11:03
8426760 to
2206a90
Compare
Benchmark ResultMaster commit hash: No major diffs! Other queries
|
royi-luo
approved these changes
Sep 9, 2025
andyfengHKU
force-pushed
the
issue-5937
branch
from
September 9, 2025 15:17
9b81a7e to
c398707
Compare
andyfengHKU
force-pushed
the
issue-5937
branch
from
September 10, 2025 14:21
d035936 to
cdfdda8
Compare
andyfengHKU
force-pushed
the
issue-5937
branch
from
September 10, 2025 15:28
ae68a7c to
cbdbb27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reworks our parameter handling strategy.
We no longer require all input parameters to match a placeholder. Unmatched input will be ignored. This should fix #5973.
In addition, I try to provide a more consistent (more reasonable) behavior across
prepare, prepareWithParam & execute. In this PR, user canprepare; orprepareWithParamAt the time
executeis called, all parameters should be presented otherwise aParameter not foundexception will be thrown.