Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Rework parameter handling - #5990

Merged
andyfengHKU merged 3 commits into
masterfrom
issue-5937
Sep 11, 2025
Merged

andyfengHKU merged 3 commits into
masterfrom
issue-5937

Conversation

@andyfengHKU

@andyfengHKU andyfengHKU commented Sep 9, 2025 •

Copy link
Copy Markdown
Contributor

Description

This PR reworks our parameter handling strategy.

We no longer require all input parameters to match a placeholder. Unmatched input will be ignored. This should fix #5973.

In addition, I try to provide a more consistent (more reasonable) behavior across prepare, prepareWithParam & execute. In this PR, user can

  • Not provide any parameter using prepare; or
  • Provide partial parameter using prepareWithParam

At the time execute is called, all parameters should be presented otherwise a Parameter not found exception will be thrown.

@github-actions

github-actions Bot commented Sep 9, 2025 •

Copy link
Copy Markdown

Benchmark Result

Master commit hash: 035a5b491c8f0e7574ce82d247a9619a9f0bcde0
Branch commit hash: c914e41bf54fe2de5d944e11016bbc0f822c64f8

No major diffs!

Other queries
Query Group Query Name Mean Time - Commit (ms)
aggregation q24 704.74
aggregation q28 7736.78
filter q14 60.89
filter q15 66.00
filter q16 278.69
filter q17 383.15
filter q18 1830.44
filter zonemap-node 23.65
filter zonemap-node-lhs-cast 24.07
filter zonemap-node-null 23.60
filter zonemap-rel 5513.55
fixed_size_expr_evaluator q07 620.07
fixed_size_expr_evaluator q08 902.86
fixed_size_expr_evaluator q09 905.74
fixed_size_expr_evaluator q10 191.49
fixed_size_expr_evaluator q11 190.35
fixed_size_expr_evaluator q12 168.97
fixed_size_expr_evaluator q13 1500.09
fixed_size_seq_scan q23 49.64
join q29 746.18
join q30 1627.49
join q31 6.66
join SelectiveTwoHopJoin 50.31
ldbc_snb_ic q35 9.26
ldbc_snb_ic q36 84.79
ldbc_snb_is q32 5.49
ldbc_snb_is q33 16.43
ldbc_snb_is q34 1.31
limit push-down-limit-into-distinct 2040.49
multi-rel multi-rel-large-scan 1558.58
multi-rel multi-rel-lookup 8.25
multi-rel multi-rel-small-scan 180.83
order_by q25 68.14
order_by q26 404.15
order_by q27 1290.94
recursive_join recursive-join-bidirection 341.95
recursive_join recursive-join-dense 7093.74
recursive_join recursive-join-path 23705.83
recursive_join recursive-join-sparse 9.51
recursive_join recursive-join-trail 7043.84
scan_after_filter q01 116.02
scan_after_filter q02 96.15
shortest_path_ldbc100 q37 157.33
shortest_path_ldbc100 q38 324.31
shortest_path_ldbc100 q39 103.79
shortest_path_ldbc100 q40 504.95
var_size_expr_evaluator q03 2112.20
var_size_expr_evaluator q04 2154.11
var_size_expr_evaluator q05 2579.42
var_size_expr_evaluator q06 1261.21
var_size_seq_scan q19 1335.88
var_size_seq_scan q20 2615.77
var_size_seq_scan q21 2155.33
var_size_seq_scan q22 108.97

Comment thread test/api/api_test.cpp
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: kuzu_query_result_to_string is advancing the wrong iterator

2 participants