feat(m663 Polish): SC-003/SC-005/SC-006 tests + close-out (closes #605) - #712
Merged
Conversation
Final m663 shipment. Closes GitHub issue #605 — every SC verified. ## Tests Three new integration-style tests in `cache_probe/mod.rs::tests` (placed there so they can access `pub(super) EcosystemProbe` without exposing internals): - **`m663_sc003_cross_ecosystem_dispatch_matches_correct_probe`** — feeds paths from Maven/Go/Cargo/RubyGems, asserts each probe matches its own path and yields the expected PURL. First-match- wins dispatch order verified. - **`m663_sc005_non_cache_path_all_probes_decline`** — feeds a random path with every env var unset; asserts all 6 probes return None (pipeline continues to deps.dev). - **`m663_sc006_microbenchmark_p95_bounded`** — 100k warm-path timing sweep, asserts p95 ≤ 5 ms. Regression guard against accidental O(n) walkers or unbounded I/O sneaking into the probe path. Typical local timing: ~1-10 µs per path (huge headroom). All 24 m663 tests pass (21 per-probe + 3 SC). Full pre-PR gate green. ## Spec close-out `specs/663-cache-probe-resolver/spec.md` now carries a full close-out section with PR list, final tally, deviations from plan, and SC-by-SC verification table. ## Memory ref `reference_cache_probe_resolver.md` — chain position, six probes, Q1 decline semantics, C152 wire signal, deferred items (pnpm CA store, universal-annotation broader wiring). ## Deferred (follow-on) - **Pnpm content-addressed store** — needs `.package-lock.json` cross-ref to resolve `<hash>` back to name+version - **Universal `waybill:resolver-tier` emission** across the other 10 resolvers — the catalog row + extractor already register unconditionally, so the follow-on is a pure emit-site wire-up Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
3 tasks
mlieberman85
added a commit
that referenced
this pull request
Aug 21, 2026
`spdx3-validate` fetches SPDX schemas (spdx-model.ttl, spdx-json-schema.json, spdx-context.jsonld) from spdx.org on EVERY invocation via `urllib.request.urlopen` and `rdflib.Graph.parse(url)`. When the GHA runner sees a transient TCP reset or DNS blip, the tool fails with `ConnectionResetError: [Errno 104] Connection reset by peer` — even though the underlying SBOM output is valid. Bit us on PR #710 (m663 US3) and #712 (m663 Polish): fresh CI runs that were identical to previous passing runs, failing purely because the runner's network hiccuped mid-schema-fetch. ## Fix `run_validator` now retries up to 3 times with exponential backoff (500ms → 1s → 2s) when the tool's output matches transient network signatures: - `ConnectionResetError` - `Connection reset by peer` - `URLError` - `urlopen error` - `TimeoutError` - `temporary failure in name resolution` Real SPDX violations don't match any of these strings and short- circuit on the first attempt (no retry latency added to genuine failures). ## Not addressed here - Persistent network outage in the runner still fails after 3 attempts — appropriate; a persistent outage isn't flakiness, and we shouldn't silently pass conformance without actually validating. - The underlying "spdx3-validate fetches over the network every run" design isn't fixed. The tool is upstream (JPEWdev/spdx3-validate); we don't own it. Vendoring the schemas would need a fork. ## Test Verified locally with the full spdx3_conformance suite (15/15 pass). No test-behavior change on the happy path. Pre-PR gate green. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
4 tasks
mlieberman85
added a commit
that referenced
this pull request
Aug 27, 2026
Cuts a stable v0.3.0. 43 commits since v0.2.0 with substantial feature additions: Feature highlights (grouped): * Resolvers + graph completeness: - m663 (#708, #709, #710, #712): local cache-probe resolver — reads ~/.m2, $GOMODCACHE, ~/.cargo, RubyGems, npm, pip caches for high-confidence PURL extraction without network. New C152 `waybill:resolver-tier` doc-scope annotation. - m235 (#688-#701): Gradle transitive dep-graph ladder — four-tier resolution (subprocess → cache → static → lockfile-only) with C146-C150 doc-scope + per-component annotations. - m236 (#703-#706): universalize `waybill:unresolved-reason` (C151) across all design-tier readers. * Architecture: - m664 (#715): single-pass filesystem walker — consolidates 21+ ecosystem-reader walk sites into one tree traversal per scan. 5-6× warm-cache perf improvement on large fixtures. - m665 (#719): `--no-binary-scan=<MODE>` flag — operator opt-out of Go-binary content probing. C153 `waybill:binary-scan- suppressed` doc-scope annotation across CDX/SPDX 2.3/SPDX 3. * eBPF: - m234 (#682, #686): un-pin bpf-linker to 0.11.0 via pre-built binary install + composite action + daily canary + verify script. * Fixes: - #711: verifier-friendly bound in tls_openssl::probe_ssl_read for kernel bumps. - #680: Go workspace-mode detection in mod_why preflight. - Several release.yml + cosign compat fixes (#674, #675, #681). Golden regeneration: * CDX goldens: 11 files, 1-line churn each — `metadata.tools[].version` bumped 0.2.0 → 0.3.0. * SPDX 2.3 goldens: 11 files. Version-string churn cascades into content-addressed SPDXRef-DocumentRoot-* IDs and documentNamespace URLs (both content-hashed). * SPDX 3 goldens: 11 files. Same content-addressing cascade into doc-/pkg-/anno-/rel- IRIs. Verified: normalized+sorted diff on all 33 goldens shows zero semantic change beyond the version string per project memory `feedback_verify_golden_churn_normalized`. Also updates `waybill-cli/tests/fixtures/pkg_alias_binding/image- baz.cdx.json` (same one-line version bump on an out-of-tree regression fixture). Skipping local pre-PR per project memory `feedback_release_bump_prepr_slow` — version bump invalidates the full compile cache so pre-PR takes 30+ min; CI will verify. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final m663 shipment. Closes issue #605 — every SC verified.
Builds on PR #708 (US1), #709 (US2), #710 (US3), #711 (ebpf fix).
What lands here
3 new SC tests
All 24 m663 tests pass (21 per-probe + 3 SC).
Spec close-out
Full close-out at `specs/663-cache-probe-resolver/spec.md`:
Memory ref
`reference_cache_probe_resolver.md` — chain position (priority 92), six probes, Q1 decline semantics, C152 wire signal, deferred items.
m663 final tally
Test plan
🤖 Generated with Claude Code