Skip to content

Fix flaky persistent subscription nack tests #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
w1am wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix flaky persistent subscription nack tests #524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions packages/test/src/persistentSubscription/subscribeToPersistentSubscriptionToStream.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,14 @@ describe("subscribeToPersistentSubscriptionToStream", () => {
const defer = new Defer();

const nacked: string[] = [];
const ackedRetries = new Set<string>();
let finishSeen = false;

const maybeResolve = () => {
if (finishSeen && ackedRetries.size === retryCount) {
defer.resolve();
}
};

const onError = jest.fn((error) => {
defer.reject(error);
Expand All @@ -246,7 +254,8 @@ describe("subscribeToPersistentSubscriptionToStream", () => {

if (event.event.type === "finish-test") {
await subscription.ack(event);
defer.resolve();
finishSeen = true;
maybeResolve();
return;
}

Expand All @@ -261,6 +270,10 @@ describe("subscribeToPersistentSubscriptionToStream", () => {
}

await subscription.ack(event);
if (event.event.type === "retry-event") {
ackedRetries.add(event.event.id);
}
maybeResolve();
return;
});

Expand Down Expand Up @@ -331,6 +344,8 @@ describe("subscribeToPersistentSubscriptionToStream", () => {
const GROUP_NAME = "async_iter_nack_group_name";
const doSomething = jest.fn();
const nacked: string[] = [];
const ackedRetries = new Set<string>();
let finishSeen = false;

// Skip the first twenty events and retry the next 20 events.
// we should see the number of times that the `onEvent` callback
Expand Down Expand Up @@ -365,7 +380,9 @@ describe("subscribeToPersistentSubscriptionToStream", () => {

if (resolvedEvent.event.type === "finish-test") {
await subscription.ack(resolvedEvent);
break;
finishSeen = true;
if (ackedRetries.size === retryCount) break;
continue;
}

if (!nacked.includes(resolvedEvent.event.id)) {
Expand All @@ -379,6 +396,10 @@ describe("subscribeToPersistentSubscriptionToStream", () => {
}

await subscription.ack(resolvedEvent);
if (resolvedEvent.event.type === "retry-event") {
ackedRetries.add(resolvedEvent.event.id);
}
if (finishSeen && ackedRetries.size === retryCount) break;
}

expect(doSomething).toBeCalledTimes(
Expand Down
Loading