[release/v1.4] Fix nil-deref panics when listing projections - #49
Merged
w1am merged 2 commits intoJul 27, 2026
Merged
Conversation
listInternal dereferenced the Statistics stream without checking the call error (nil stream on failure) and item.Details without a nil guard; GetStatus then indexed [0] on a possibly-empty result. Guard all three: return the call error, skip items with no details, and return not-found when a named lookup yields nothing.
Skipping a nil-Details statistics frame silently dropped an entry from ListAll/ListContinuous and could turn a malformed named lookup into ResourceNotFound. A partial list with no signal is worse than a clear failure - callers can't tell a projection is missing from a bad frame, and gaffer's drift check would read the dropped projection as undeployed. Surface it as an ErrorCodeInternalServer so the caller decides how to handle it. The empty-stream case in GetStatus is still a genuine not-found and keeps its own guard.
w1am
deleted the
cherry-pick/48/ui-1893/fix-projection-list-nil-panics-release/v1.4
branch
July 27, 2026 10:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picked from #48