Skip to content

feat(overcommit): add cron worker for overcommit controller#664

Open
WangZzzhe wants to merge 1 commit into
kubewharf:mainfrom
WangZzzhe:dev/cron-overcommit
Open

feat(overcommit): add cron worker for overcommit controller#664
WangZzzhe wants to merge 1 commit into
kubewharf:mainfrom
WangZzzhe:dev/cron-overcommit

Conversation

@WangZzzhe
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

should be rebased after kubewharf/katalyst-api#95 merged

@WangZzzhe WangZzzhe force-pushed the dev/cron-overcommit branch from 4318fe2 to 5e1420d Compare July 31, 2024 07:46
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 31, 2024

Codecov Report

❌ Patch coverage is 69.17293% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.02%. Comparing base (7d9189e) to head (5e1420d).
⚠️ Report is 1159 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/overcommit/node/cron.go 74.78% 19 Missing and 10 partials ⚠️
pkg/client/control/noc.go 29.41% 7 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
+ Coverage   56.90%   57.02%   +0.11%     
==========================================
  Files         554      555       +1     
  Lines       53185    53318     +133     
==========================================
+ Hits        30265    30404     +139     
+ Misses      19123    19084      -39     
- Partials     3797     3830      +33     
Flag Coverage Δ
unittest 57.02% <69.17%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WangZzzhe WangZzzhe added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jul 31, 2024
@xu282934741 xu282934741 removed the workflow/need-review review: test succeeded, need to review label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants