Skip to content

fix(sysadvisor): fix mbm calculation logic#1171

Merged
luomingmeng merged 1 commit into
kubewharf:mainfrom
syc4704413:dev/syc/fix-mem_bw-metrics
May 29, 2026
Merged

fix(sysadvisor): fix mbm calculation logic#1171
luomingmeng merged 1 commit into
kubewharf:mainfrom
syc4704413:dev/syc/fix-mem_bw-metrics

Conversation

@syc4704413
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Bug fixes

@syc4704413 syc4704413 force-pushed the dev/syc/fix-mem_bw-metrics branch 2 times, most recently from 7ea2dfd to 5f36ef6 Compare May 29, 2026 03:13
Copy link
Copy Markdown
Collaborator

@XudongLiuHarold XudongLiuHarold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

might need to add some unit test cases

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.90%. Comparing base (970841c) to head (7ae425e).
⚠️ Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
...ric/provisioner/malachite/provisioner_calculate.go 92.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
+ Coverage   61.77%   61.90%   +0.13%     
==========================================
  Files         787      791       +4     
  Lines       74213    75113     +900     
==========================================
+ Hits        45843    46499     +656     
- Misses      23330    23529     +199     
- Partials     5040     5085      +45     
Flag Coverage Δ
unittest 61.90% <92.30%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@syc4704413 syc4704413 added the workflow/need-review review: test succeeded, need to review label May 29, 2026
@luomingmeng luomingmeng merged commit d301709 into kubewharf:main May 29, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workflow/need-review review: test succeeded, need to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants