Skip to content

fix(memory): extra resources for shared cores non-numa binding hint handler#1170

Open
JustinChengLZ wants to merge 1 commit into
kubewharf:mainfrom
JustinChengLZ:dev/shared-cores-hints-extra-resources
Open

fix(memory): extra resources for shared cores non-numa binding hint handler#1170
JustinChengLZ wants to merge 1 commit into
kubewharf:mainfrom
JustinChengLZ:dev/shared-cores-hints-extra-resources

Conversation

@JustinChengLZ
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

❌ Patch coverage is 82.75862% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.80%. Comparing base (d64650b) to head (f60245f).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...g/agent/qrm-plugins/memory/dynamicpolicy/policy.go 77.41% 5 Missing and 2 partials ⚠️
pkg/util/native/resources.go 89.74% 2 Missing and 2 partials ⚠️
...ugins/memory/dynamicpolicy/policy_hint_handlers.go 77.77% 1 Missing and 1 partial ⚠️
pkg/agent/qrm-plugins/cpu/nativepolicy/policy.go 0.00% 1 Missing ⚠️
pkg/agent/qrm-plugins/cpu/util/util.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1170      +/-   ##
==========================================
- Coverage   61.88%   61.80%   -0.08%     
==========================================
  Files         791      791              
  Lines       74791    74919     +128     
==========================================
+ Hits        46283    46305      +22     
- Misses      23445    23524      +79     
- Partials     5063     5090      +27     
Flag Coverage Δ
unittest 61.80% <82.75%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JustinChengLZ JustinChengLZ force-pushed the dev/shared-cores-hints-extra-resources branch from 6cf48d1 to f60245f Compare May 28, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant