Skip to content

metrics(qrm): mbm throttle metrics#1159

Merged
luomingmeng merged 9 commits into
kubewharf:mainfrom
h-w-chen:dev/hw-mbm-throttle-metrics
May 28, 2026
Merged

metrics(qrm): mbm throttle metrics#1159
luomingmeng merged 9 commits into
kubewharf:mainfrom
h-w-chen:dev/hw-mbm-throttle-metrics

Conversation

@h-w-chen
Copy link
Copy Markdown
Collaborator

@h-w-chen h-w-chen commented May 20, 2026

What type of PR is this?

Enhancements - metrics

What this PR does / why we need it:

To have metrics that indicate which are being throttled with their mem bandwidth by qrm-mb-plugin.
the metrics it emits:

2 metrics introduced:

  • name: katalyst.mbm_ccd_suppressed
    tags:
    • domain ID (numa id)
    • resctrl group name
    • ccd id
    • suppression type: domain_stress, ccd_limit
  • name: katalyst.mbm_load_suppressed
    tags:
    • namespace
    • pod_name
    • psm
    • suppression type

@h-w-chen h-w-chen requested a review from luomingmeng as a code owner May 20, 2026 01:01
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 56.80751% with 92 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.80%. Comparing base (d64650b) to head (4720aee).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/agent/qrm-plugins/mb/policy/plugin.go 45.83% 51 Missing and 1 partial ⚠️
...g/agent/qrm-plugins/mb/advisor/priority_advisor.go 57.62% 23 Missing and 2 partials ⚠️
...nt/qrm-plugins/mb/advisor/uniq_priority_advisor.go 66.66% 5 Missing and 5 partials ⚠️
...gent/qrm-plugins/mb/advisor/pcontroller_advisor.go 82.14% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1159      +/-   ##
==========================================
- Coverage   61.88%   61.80%   -0.08%     
==========================================
  Files         791      791              
  Lines       74791    75096     +305     
==========================================
+ Hits        46283    46415     +132     
- Misses      23445    23591     +146     
- Partials     5063     5090      +27     
Flag Coverage Δ
unittest 61.80% <56.80%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@h-w-chen h-w-chen changed the title WIP: metrics(qrm): mbm throttle metrics metrics(qrm): mbm throttle metrics May 20, 2026
@h-w-chen h-w-chen added the workflow/need-review review: test succeeded, need to review label May 20, 2026
@h-w-chen h-w-chen force-pushed the dev/hw-mbm-throttle-metrics branch 2 times, most recently from 07a7e3b to 299d34c Compare May 26, 2026 05:26
Comment thread pkg/agent/qrm-plugins/mb/advisor/pcontroller_advisor.go
Comment thread pkg/agent/qrm-plugins/mb/advisor/priority_advisor.go Outdated
Comment thread pkg/agent/qrm-plugins/mb/advisor/priority_advisor.go
Comment thread pkg/agent/qrm-plugins/mb/policy/plugin.go Outdated
Comment thread pkg/agent/qrm-plugins/mb/policy/plugin.go Outdated
Comment thread pkg/agent/qrm-plugins/mb/policy/plugin.go Outdated
@h-w-chen h-w-chen force-pushed the dev/hw-mbm-throttle-metrics branch 2 times, most recently from 0f7f90f to 5422c42 Compare May 27, 2026 05:42
@h-w-chen h-w-chen force-pushed the dev/hw-mbm-throttle-metrics branch from 5422c42 to 700f37a Compare May 27, 2026 07:07
@h-w-chen h-w-chen force-pushed the dev/hw-mbm-throttle-metrics branch from 7f19304 to b433bf7 Compare May 27, 2026 18:52
Comment thread pkg/agent/qrm-plugins/mb/advisor/priority_advisor.go Outdated
Comment thread pkg/agent/qrm-plugins/mb/policy/plugin.go Outdated
@luomingmeng luomingmeng merged commit 002341d into kubewharf:main May 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workflow/need-review review: test succeeded, need to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants