Fix VMNonRecoverableOSPanic to reflect both >0 and >5 cases#390
Fix VMNonRecoverableOSPanic to reflect both >0 and >5 cases#390avlitman wants to merge 1 commit into
Conversation
Signed-off-by: avlitman <alitman@redhat.com>
kubevirt-prow
Bot
added
the
dco-signoff: yes
📝 WalkthroughWalkthroughThe change updates the alert description in the VMNonRecoverableOSPanic runbook, removing the specific "more than 5" panic threshold wording and replacing it with a general statement that the alert triggers when non-recoverable guest OS panics have occurred within the last 24 hours. The rest of the metric-based explanation is unchanged. Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Review notes: Solid, focused edit — docs/runbooks/VMNonRecoverableOSPanic.md lines 5-6 read cleanly and match the underlying alert logic. One thing worth double-checking: confirm the actual PrometheusRule query for this alert doesn't still reference a specific panic count threshold (e.g., Warning Review ran into problems🔥 ProblemsLinked repositories: Your configuration references 10 linked repositories, but your current plan allows 0. Analyzed ``, skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/runbooks/VMNonRecoverableOSPanic.md (1)
37-38: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valuePrefix shell examples with
$per runbook style.The
kubectlcommands lack the required$prefix. As per path instructions, shell examples must be prefixed with$to distinguish commands from output and maintain consistency with other runbooks.- kubectl get vmi -n $NAMESPACE $VM_NAME -o wide - kubectl describe vmi -n $NAMESPACE $VM_NAME + $ kubectl get vmi -n $NAMESPACE $VM_NAME -o wide + $ kubectl describe vmi -n $NAMESPACE $VM_NAME- POD=$(kubectl get pod -n $NAMESPACE -l kubevirt.io/domain=$VM_NAME -o name | head -n1) - kubectl describe $POD -n $NAMESPACE - kubectl logs $POD -n $NAMESPACE -c compute --previous - kubectl logs $POD -n $NAMESPACE -c compute + $ POD=$(kubectl get pod -n $NAMESPACE -l kubevirt.io/domain=$VM_NAME -o name | head -n1) + $ kubectl describe $POD -n $NAMESPACE + $ kubectl logs $POD -n $NAMESPACE -c compute --previous + $ kubectl logs $POD -n $NAMESPACE -c computeAlso applies to: 60-63
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/runbooks/VMNonRecoverableOSPanic.md` around lines 37 - 38, The shell command examples in the runbook are missing the required `$ ` prefix, so update the affected examples to match runbook style and consistency. Fix the command blocks containing kubectl usage by adding `$ ` before each shell command in the relevant sections, including the examples around the VM inspection commands and the later related commands, so they are clearly distinguished from output.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/runbooks/VMNonRecoverableOSPanic.md`:
- Around line 37-38: The shell command examples in the runbook are missing the
required `$ ` prefix, so update the affected examples to match runbook style and
consistency. Fix the command blocks containing kubectl usage by adding `$ `
before each shell command in the relevant sections, including the examples
around the VM inspection commands and the later related commands, so they are
clearly distinguished from output.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: a082c031-b115-4b7f-ab9a-61aa51b8904a
📒 Files selected for processing (1)
docs/runbooks/VMNonRecoverableOSPanic.md
1 participant
Remove the specific
> 5 panicsthreshold from the runbook's Meaning section, making it applicable to both the KubeVirt (critical, > 5) and HCO (warning, > 0) variants of the VMNonRecoverableOSPanic alert.Release note: