Skip to content

Conversation

@CatherineF-dev
Copy link
Contributor

Description

Issue

Closes: #

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lmktfy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 28, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2025
@CatherineF-dev CatherineF-dev changed the title Update horizontal-pod-autoscale.md Add more description about HorizontalPodAutoscaler Object Nov 28, 2025
@netlify
Copy link

netlify bot commented Nov 28, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0bf37c7
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6928f21f081e81000873ba97
😎 Deploy Preview https://deploy-preview-53476--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy
Copy link
Member

lmktfy commented Nov 29, 2025

/sig autoscaling

@k8s-ci-robot k8s-ci-robot added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Nov 29, 2025
[HorizontalPodAutoscaler Object](/docs/reference/generated/kubernetes-api/{{< param "version" >}}/#horizontalpodautoscaler-v2-autoscaling).

HorizontalPodAutoscaler Object contains Spec and Status.
The `Spec` contains 4 fields:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of a nit, but when writing out numbers, it would be best to use the word:

Suggested change
The `Spec` contains 4 fields:
The `Spec` contains four fields:

3. Metrics: scale based on what.
4. Behavior: ScaleUp and ScaleDown, which contains Stabilitzation Window and Policies.

The `Metrics` supports 4 different sources:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.


| Metric Type | Source of Data | Logic Applied | Typical Example |
| :--- | :--- | :--- | :--- |
| **Resource** | CPU / RAM usage (Built-in) | Usage vs. Request % | Scale when CPU > 80% |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nit, but it doesn't feel right to me to have these in a different order than they are listed just prior to the table.

Maybe even alphabetize the list?

| **External** | Outside the cluster | Absolute value | Scale when `pubsub_queue_length` > 1000 |


The `Status` contains 3 information:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `Status` contains 3 information:
The `Status` contains three pieces of information:



The `Status` contains 3 information:
1. Replicas info: CurrentReplicas and DesiredReplicas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Replicas info: CurrentReplicas and DesiredReplicas
1. Replica info: CurrentReplicas and DesiredReplicas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants