-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Add more description about HorizontalPodAutoscaler Object #53476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/sig autoscaling |
| [HorizontalPodAutoscaler Object](/docs/reference/generated/kubernetes-api/{{< param "version" >}}/#horizontalpodautoscaler-v2-autoscaling). | ||
|
|
||
| HorizontalPodAutoscaler Object contains Spec and Status. | ||
| The `Spec` contains 4 fields: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort of a nit, but when writing out numbers, it would be best to use the word:
| The `Spec` contains 4 fields: | |
| The `Spec` contains four fields: |
| 3. Metrics: scale based on what. | ||
| 4. Behavior: ScaleUp and ScaleDown, which contains Stabilitzation Window and Policies. | ||
|
|
||
| The `Metrics` supports 4 different sources: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
|
|
||
| | Metric Type | Source of Data | Logic Applied | Typical Example | | ||
| | :--- | :--- | :--- | :--- | | ||
| | **Resource** | CPU / RAM usage (Built-in) | Usage vs. Request % | Scale when CPU > 80% | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another nit, but it doesn't feel right to me to have these in a different order than they are listed just prior to the table.
Maybe even alphabetize the list?
| | **External** | Outside the cluster | Absolute value | Scale when `pubsub_queue_length` > 1000 | | ||
|
|
||
|
|
||
| The `Status` contains 3 information: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The `Status` contains 3 information: | |
| The `Status` contains three pieces of information: |
|
|
||
|
|
||
| The `Status` contains 3 information: | ||
| 1. Replicas info: CurrentReplicas and DesiredReplicas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 1. Replicas info: CurrentReplicas and DesiredReplicas | |
| 1. Replica info: CurrentReplicas and DesiredReplicas |
Description
Issue
Closes: #