-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Add AverageValue example for HPA resource metrics #53467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @light0011! |
- Added example showing how to use AverageValue target type - Clarified that AverageValue scales based on actual consumption - Addresses issue kubernetes#53447
78ef91c to
a78bff6
Compare
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
omerap12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t this be moved to the HPA walkthrough rather than the concept section?
Per review feedback from @omerap12, moved the example to the walkthrough document in the 'Autoscaling on multiple metrics' section where AverageValue is first explained. - Added practical example showing CPU scaling with AverageValue - Clarified use cases for absolute value scaling - Provided context on when to use this approach vs Utilization Closes: kubernetes#53447
Per review feedback from @omerap12, moved the example to the walkthrough document in the 'Autoscaling on multiple metrics' section where AverageValue is first explained. - Added practical example showing CPU scaling with AverageValue - Clarified use cases for absolute value scaling - Provided context on when to use this approach vs Utilization Closes: kubernetes#53447
|
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@omerap12 Thanks for the feedback! I've moved the example to the walkthrough document. Changes made:
The example now fits better in the practical tutorial context. Please take another look when you have a chance! |
Description
This PR adds a practical example to the HPA documentation demonstrating how to use the
AverageValuetarget type for resource-based scaling.Changes:
AverageValueusage for CPU and memoryAverageValuescales based on actual resource consumption rather than resource requestsUtilization-based scalingThis enhancement helps users understand when and how to use absolute resource values for autoscaling, particularly useful when resource requests are not defined or when absolute thresholds are preferred.
Issue
Closes: #53447