node-readiness-controller: add scale test as presubmit job

[vitorfloriano]

This PR adds the scalability test merged in kubernetes-sigs/node-readiness-controller#284 as a presubmit job.

The following configuration is used:

KWOK_RUNTIME="binary"
NODE_COUNT=1000
ENFORCEMENT_MODE="continuous"

xref: kubernetes-sigs/node-readiness-controller#409

[vitorfloriano]

/cc @ajaysundark @Priyankasaggu11929

[ajaysundark]

/lgtm

[ajaysundark]

Once we get confidence, we could update this to keep presubmits only in release branches and periodics in main

[ajaysundark]

nit: you could skip this as this is default. It is odd to expose this implementation detail config outside.

[vitorfloriano]

Just thought of establishing a pattern for the next tests, in case we add variants. Also, it is self-documenting and can help identify what is being tested without having to look up the default implementation.

[vitorfloriano]

/hold

Could we try to get #37693 merged first for validation then we could enable the JUnit report by default?

[Priyankasaggu11929]

keeping the hold

/lgtm
/approve

[vitorfloriano]

@Priyankasaggu11929 @ajaysundark The JUnit report worked as expected and it is now possible to visualize the metrics in graph view:

https://testgrid.k8s.io/sig-node-node-readiness-controller#pull-node-readiness-controller-junit-report-canary&graph-metrics=kube_api_requests_rate&graph-metrics=cpu_cores_peak&graph-metrics=reconcile_time_p50&graph-metrics=resident_memory_avg&width=90

Should we use this as default?

[Priyankasaggu11929]

@Priyankasaggu11929 @ajaysundark The JUnit report worked as expected and it is now possible to visualize the metrics in graph view:

https://testgrid.k8s.io/sig-node-node-readiness-controller#pull-node-readiness-controller-junit-report-canary&graph-metrics=kube_api_requests_rate&graph-metrics=cpu_cores_peak&graph-metrics=reconcile_time_p50&graph-metrics=resident_memory_avg&width=90

Should we use this as default?

let's do it. Even if we do some other UI later, no harm in keeping these in testgrid too.

[vitorfloriano]

@Priyankasaggu11929 should we just add the JUnit report flag to this prowjob or change the actual test to enable it by default?

[Priyankasaggu11929]

@Priyankasaggu11929 should we just add the JUnit report flag to this prowjob or change the actual test to enable it by default?

here is better, i like the documentation in the job itself.

[vitorfloriano]

I added the JUnit report. PTAL.

/unhold

[Priyankasaggu11929]

/lgtm
/approve

Thank you!

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Priyankasaggu11929, vitorfloriano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• config/jobs/kubernetes-sigs/node-readiness-controller/OWNERS [Priyankasaggu11929]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubernetes-prow]

@vitorfloriano: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

• key node-readiness-controller-presubmits.yaml using file config/jobs/kubernetes-sigs/node-readiness-controller/node-readiness-controller-presubmits.yaml

Details

In response to this:

This PR adds the scalability test merged in kubernetes-sigs/node-readiness-controller#284 as a presubmit job.

The following configuration is used:

KWOK_RUNTIME="binary"
NODE_COUNT=1000
ENFORCEMENT_MODE="continuous"

xref: kubernetes-sigs/node-readiness-controller#409

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.