Skip to content

Remove jobs no longer used and also update tooling #35986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove jobs no longer used and also update tooling #35986

wants to merge 2 commits into from
+36 −231

Conversation

@aojea
Copy link
Member

@aojea aojea commented Nov 28, 2025

The following jobs are no longer working:

https://testgrid.k8s.io/sig-network-gce#gce-cos-1.11-ingress
https://testgrid.k8s.io/sig-network-gce#gce-cos-1.12-ingress

These jobs are automatically generated by the tools seems to require an update

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject labels Nov 28, 2025
@k8s-ci-robot k8s-ci-robot added area/testgrid sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 28, 2025
@aojea
Copy link
Member Author

aojea commented Nov 28, 2025

/assign @dims @bowei @ameukam @BenTheElder

@aojea aojea force-pushed the net-gce-ingress branch 2 times, most recently from 614ae9a to d2a9b2b Compare November 29, 2025 18:33
aojea added 2 commits November 29, 2025 20:28
@aojea
update python version
b4521f2 
use a more recent version and update the dependencies
@aojea
remove permafailing jobs
0c2d72f
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Nov 29, 2025
ameukam
ameukam reviewed Nov 30, 2025
View reviewed changes
config/jobs/kubernetes/kops/build_jobs.py
Comment on lines +122 to +124
kops_image = None
kops_ssh_user = None
kops_ssh_key_path = None
Copy link
Member

@ameukam ameukam Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll probably do this in a separate PR. AFAIK this script don't rely on the repo dependencies. cc @hakman

Copy link
Member

@hakman hakman Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might, do you see any issue with the changes, they seem minor?

Copy link
Member Author

@aojea aojea Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It got flagged by the linter after the upgrade

BenTheElder
BenTheElder reviewed Dec 1, 2025
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the python change looks fine, though I don't know if everything works with the dependency updates, or if the dependencies meet the license policy

@aojea
Copy link
Member Author

aojea commented Dec 2, 2025

we need to update the dependencies in order to be able to run the releng script 🤷

@ameukam
Copy link
Member

ameukam commented Dec 2, 2025

/lgtm
/hold

Drop the hold when you are ready

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 3, 2025

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@ameukam ameukam ameukam left review comments

@bowei bowei Awaiting requested review from bowei

@cjwagner cjwagner Awaiting requested review from cjwagner

+1 more reviewer

@hakman hakman hakman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dims dims

@bowei bowei

@BenTheElder BenTheElder

@ameukam ameukam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/kettle area/metrics area/release-eng Issues or PRs related to the Release Engineering subproject area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aojea @k8s-ci-robot @ameukam @BenTheElder @hakman @dims @bowei