Skip to content

Conversation

@Jimmykhangnguyen
Copy link

What type of PR is this:

/kind documentation

What this PR does / why we need it:

This PR updates the Release Notes Draft to v1.35.0-alpha.2

Which issue(s) this PR fixes:

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jimmykhangnguyen
Once this PR has been reviewed and has the lgtm label, please assign drewhagen for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from rayandas October 25, 2025 18:48
@k8s-ci-robot k8s-ci-robot added the area/release-team Issues or PRs related to the release-team subproject label Oct 25, 2025
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 25, 2025
@Jimmykhangnguyen Jimmykhangnguyen changed the title Update release notes draft to version v1.35.0-alpha.12 Update release notes draft to version v1.35.0-alpha.2 Oct 25, 2025
Copy link

@kernel-kun kernel-kun Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@sayanchowdhury sayanchowdhury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I would also suggest to run krel validate once if not already.

@kernel-kun
Copy link

Thanks for syncing the changes back to .json and .md
I'm just a bit skeptical around replacing \u003c with < directly within the .json file but it seems the changes are being rendered correctly without issues within .md itself
image
image
image
Ref. https://github.com/Jimmykhangnguyen/sig-release/blob/1feedb1a4fd27ae3fad6fafacbd2ee1f65024c7f/releases/release-1.35/release-notes/release-notes-draft.md

We should be good to go with this PR's approval IMO
Great work @Jimmykhangnguyen!!

Copy link
Member

@sayanchowdhury sayanchowdhury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - just one change in json and md.

@Jimmykhangnguyen Jimmykhangnguyen force-pushed the release-notes-draft-v1.35.0-alpha.2 branch from 647a1ee to 11400fb Compare October 29, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants